[PM-23608] Add generateTotp overload with CipherListView parameter#5509
Closed
SaintPatrck wants to merge 1 commit intomainfrom
Closed
[PM-23608] Add generateTotp overload with CipherListView parameter#5509SaintPatrck wants to merge 1 commit intomainfrom
SaintPatrck wants to merge 1 commit intomainfrom
Conversation
SaintPatrck
requested review from
a team,
brian-livefront and
david-livefront
as code owners
Contributor
|
Great job, no security vulnerabilities found in this Pull Request |
app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceTest.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceImpl.kt
Outdated
Show resolved
Hide resolved
SaintPatrck
force-pushed
the
PM-23608/vault-sdk-generate-totp-cipherview
branch
from
3479a35 to
1e5c017
Compare
| suspend fun generateTotp( | ||
| userId: String, | ||
| cipherListView: CipherListView, | ||
| time: Instant, |
david-livefront
previously approved these changes
Jul 10, 2025
SaintPatrck
force-pushed
the
PM-23608/vault-sdk-generate-totp-cipherview
branch
from
1e5c017 to
b01d938
Compare
david-livefront
previously approved these changes
Jul 10, 2025
SaintPatrck
force-pushed
the
PM-23608/vault-sdk-generate-totp-cipherview
branch
from
b01d938 to
94af4bf
Compare
SaintPatrck
force-pushed
the
PM-23608/vault-sdk-generate-totp-cipherview
branch
from
94af4bf to
45fbdbf
Compare
The `VaultSdkSource` and `VaultSdkSourceImpl` classes are updated to include a new overload for the `generateTotp` method. This overload accepts a `CipherListView` parameter instead of a `String` totp parameter. This change also updates the corresponding unit tests to specify argument names. Additionally, a new utility file `CipherListViewUtil.kt` is introduced to create mock `CipherListView` objects for testing purposes.
SaintPatrck
force-pushed
the
PM-23608/vault-sdk-generate-totp-cipherview
branch
from
45fbdbf to
54ad19c
Compare
auto-merge was automatically disabled
July 11, 2025 15:39
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-23608
📔 Objective
The
VaultSdkSourceandVaultSdkSourceImplclasses are updated to include a new overload for thegenerateTotpmethod. This overload accepts aCipherListViewparameter instead of aStringtotp parameter.This change also updates the corresponding unit tests to specify argument names.
Additionally, a new utility file
CipherListViewUtil.ktis introduced to create mockCipherListViewobjects for testing purposes.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes