[PM-25143] Retain intent on Activity recreation in old OS revisions#5783
Closed
SaintPatrck wants to merge 1 commit intomainfrom
Closed
[PM-25143] Retain intent on Activity recreation in old OS revisions#5783SaintPatrck wants to merge 1 commit intomainfrom
SaintPatrck wants to merge 1 commit intomainfrom
Conversation
The `MainActivity` intent was using `makeMainActivity` which was causing intent data loss on recreation. This change uses the existing intent to prevent intent data loss. This is related to the fix for an OS bug tracked at https://issuetracker.google.com/issues/370180732 for devices that will no longer receive OS updates.
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5783 +/- ##
=======================================
Coverage 83.84% 83.84%
=======================================
Files 692 692
Lines 53005 53005
Branches 7309 7309
=======================================
Hits 44442 44442
Misses 5994 5994
Partials 2569 2569 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-25143
📔 Objective
The
MainActivityintent was usingmakeMainActivitywhich wascausing intent data loss on recreation. This change uses the existing
intent to prevent intent data loss.
This is related to the fix for an OS bug tracked at
https://issuetracker.google.com/issues/370180732 for devices
that will no longer receive OS updates.
📸 Screenshots
Coming soon!
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes