PM-28545: Remove the compatibility mode toggle from the Autofill screen

[david-livefront]

🎟️ Tracking

PM-28545

📔 Objective

This PR removes the Autofill compatibility mode toggle from the app. The functionality that it controlled is now on by default.

📸 Screenshots

Before	After

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[claude]

Claude finished @david-livefront's task —— View job

---

Code Review Complete

Reviewing PR: PM-28545: Remove the compatibility mode toggle from the Autofill screen

Todo List

• Evaluate PR title and description quality
• Review data layer changes (SettingsDiskSource, SettingsRepository)
• Review UI layer changes (AutoFillScreen, AutoFillViewModel)
• Review parser changes (AutofillParserImpl)
• Review test updates
• Check for orphaned references
• Post review findings

---

Overall Assessment: APPROVE

This PR successfully removes the compatibility mode toggle feature from the Autofill settings screen. The implementation is clean, thorough, and follows established patterns. All references to the feature have been properly removed across the data, UI, and test layers.

Summary

The changes properly remove the compatibility mode toggle while making the functionality always-on by default. The removal is systematic:

Data Layer (SettingsDiskSource, SettingsRepository):

• Removed isAutofillWebDomainCompatMode property and backing SharedPreferences key (AUTOFILL_WEB_DOMAIN_COMPATIBILITY)

UI Layer (AutoFillScreen, AutoFillViewModel):

• Removed toggle UI component and associated dialog
• Removed event handlers and state management
• Removed 3 related string resources

Parser Layer (AutofillParserImpl:93):

• Removed conditional check .takeIf { settingsRepository.isAutofillWebDomainCompatMode }, making URL bar website detection always active

Tests:

• All corresponding test cases removed appropriately

Minor Finding

Finding 1: ⚠️ Screenshot issue in PR description

Details

The "Before" and "After" screenshots in the PR description appear to be identical - both show the compatibility mode toggle still present. The "After" screenshot should show the Autofill screen WITHOUT the "Use compatibility mode for browser autofill" toggle.

This doesn't affect the code quality, but it may confuse reviewers trying to verify the visual changes.

Location: PR description screenshots

Recommendation: Update the "After" screenshot to show the actual post-change UI state.

---

[github-actions]

Checkmarx One – Scan Summary & Details – ea84076d-cceb-48f0-9403-aa3cc50fef89

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.20%. Comparing base (946b078) to head (bc318db).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6188      +/-   ##
==========================================
- Coverage   85.22%   85.20%   -0.02%     
==========================================
  Files         724      724              
  Lines       53008    52930      -78     
  Branches     7710     7701       -9     
==========================================
- Hits        45175    45101      -74     
+ Misses       5143     5140       -3     
+ Partials     2690     2689       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.