Skip to content

[PM-14880] ci: Update feature labels#6346

Merged
vvolkgang merged 2 commits intomainfrom
vvolkgang/update-labels2
Jan 12, 2026
Merged

[PM-14880] ci: Update feature labels#6346
vvolkgang merged 2 commits intomainfrom
vvolkgang/update-labels2

Conversation

@vvolkgang
Copy link
Member

🎟️ Tracking

PM-14880

📔 Objective

Updates feature labels by consolidating new-feature and enhancement into a single feature-app and adding feature-tool. The latter will be used for changes TestHarness and similar internal tools changes.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang requested a review from a team as a code owner January 12, 2026 16:44
@github-actions github-actions bot added the t:ci Change Type - Updates to automated workflows label Jan 12, 2026
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.49%. Comparing base (41dfc2b) to head (1218844).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6346   +/-   ##
=======================================
  Coverage   85.49%   85.49%           
=======================================
  Files         764      764           
  Lines       54724    54724           
  Branches     7881     7881           
=======================================
  Hits        46785    46785           
  Misses       5201     5201           
  Partials     2738     2738           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details2de0eab2-8401-4bb3-9afe-edd7c88f5433

Great job! No new security vulnerabilities introduced in this pull request

@vvolkgang vvolkgang enabled auto-merge January 12, 2026 17:03
@SaintPatrck SaintPatrck added the ai-review Request a Claude code review label Jan 12, 2026
@claude
Copy link
Contributor

claude bot commented Jan 12, 2026

Claude finished @vvolkgang's task in 1m 52s —— View job


Code Review Summary

Change Type: Infrastructure - CI label configuration update
Risk Level: Low
Files Changed: 1 file (+7/-3 lines)


Overview

This PR consolidates feature-related labels by:

  • Renaming t:new-featuret:feature-app
  • Replacing t:enhancement with t:feature-tool for internal tools (TestHarness, etc.)
  • Adding .checkmarx/ to CI-related path patterns

Analysis

Positive aspects:

  • Clean, focused change with clear intent
  • JSON structure is valid and well-organized
  • Backward compatibility maintained (.github/release.yml retains old labels for historical PRs)
  • Path pattern mappings are logical:
    • testharness/t:feature-tool (correctly categorizes internal tool changes)
    • FIDO2 assets → t:feature-app (appropriate for app features)
    • .checkmarx/t:ci (security scanning configuration belongs in CI category)

Title pattern behavior:
The new t:feature-tool uses "tool" as a title pattern. Contributors must use "tool:" prefix in PR titles for TestHarness changes. Other patterns like "fix:" and "chore:" will match first, preventing false positives.

Removed patterns:
The removal of "enhancement", "enh", "impr" title patterns means PRs with these keywords will fall back to t:misc. This appears intentional to simplify the labeling taxonomy.

Recommendation

APPROVED - No blocking issues identified.

This is a clean infrastructure change that achieves its stated goal. The new label taxonomy is clearer (app features vs. internal tools), and the implementation is sound.


Review completed with zero findings requiring inline comments.


Generated by Claude Code Review Agent | Bitwarden Android

@vvolkgang vvolkgang added this pull request to the merge queue Jan 12, 2026
Merged via the queue into main with commit d86959b Jan 12, 2026
19 checks passed
@vvolkgang vvolkgang deleted the vvolkgang/update-labels2 branch January 12, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:ci Change Type - Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants