End subtext and end icon support to BitwardenGroupItem

[david-livefront]

🎟️ Tracking

N/A

📔 Objective

This PR adds support for the BitwardenGroupItem to display subtext and a end icon which will be needed for the Archive feature. Additionally, I have migrated the composable to utilize the IconData class and BitwardenIcon class for extra reusability.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[claude]

Claude finished @david-livefront's task in 2m 7s —— View job

---

Code Review Summary

PR Objective: Add subLabel and endIcon support to BitwardenGroupItem and migrate from Painter/Icon to IconData/BitwardenIcon for consistency.

Review Assessment: APPROVED with minor suggestion

This PR successfully enhances the BitwardenGroupItem component in preparation for the Archive feature. The implementation follows established patterns, maintains code quality, and updates all call sites appropriately.

---

Findings

🎨 SUGGESTED (1)

1. Outdated KDoc summary - View comment
   • The component description doesn't mention the new subLabel and endIcon parameters
   • Minor documentation improvement only

---

Analysis

Strengths:

• ✅ Follows established IconData/BitwardenIcon pattern from :ui module
• ✅ All call sites updated consistently across SendContent, VaultItemListingContent, and VaultContent
• ✅ Proper use of Compose best practices (Column with weight, optional parameters with let)
• ✅ Breaking API change is acceptable - internal component with all usages updated
• ✅ Test tag support migrated properly from parameter to IconData.Local.testTag
• ✅ Code style adheres to Bitwarden guidelines

Architecture Compliance:

• Component remains in appropriate module (:app/platform/components)
• No security implications (UI-only change)
• No business logic impact

API Changes:

• startIcon: Painter → IconData.Local (Breaking but intentional)
• startIconTestTag: Removed parameter → Moved to IconData.Local.testTag
• Added: subLabel: String? = null
• Added: endIcon: IconData.Local? = null

All breaking changes handled correctly with all call sites updated in the same PR.

---

Recommendation

APPROVED - The implementation is solid and follows Bitwarden patterns. The single documentation suggestion is minor and doesn't block approval.

[claude]

SUGGESTED: The KDoc summary is outdated after adding the new parameters. Consider updating the description on lines 25-26 to mention subLabel and endIcon:

Suggested change

	* @param startIcon The [IconData] object used to draw the icon at the start of the group item.
	/**
	* A reusable composable function that displays a group item.
	* The list item consists of a start icon, a label, an optional sublabel, a supporting label,
	* an optional end icon, and an optional divider.

[github-actions]

Checkmarx One – Scan Summary & Details – 1218a7cf-a7a1-4a70-aff4-4ca5724d4bd6

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.47%. Comparing base (be365ee) to head (7509119).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6349   +/-   ##
=======================================
  Coverage   85.47%   85.47%           
=======================================
  Files         764      764           
  Lines       54748    54753    +5     
  Branches     7896     7896           
=======================================
+ Hits        46794    46799    +5     
  Misses       5211     5211           
  Partials     2743     2743           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[david-livefront]

Thanks @andrebispo5