PM-29694: Update archive empty state

[david-livefront]

🎟️ Tracking

PM-29694

📔 Objective

This PR updates the empty state for the vault listing screen for archives. This update copy and adds a new illustration. Additionally, the generic BitwardenEmptyContent was applied to improve code re-usability.

📸 Screenshots

Before	After

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[claude]

Claude finished @david-livefront's task in 1m 28s —— View job

---

Code Review: PM-29694 - Update archive empty state

Result: APPROVED

Summary

This PR successfully updates the empty state for the archive vault listing screen by:

• Updating copy from "No items in archive." to a title/message format ("Archive is empty" + descriptive text)
• Adding a new illustration (ill_open_source.xml)
• Refactoring VaultItemListingEmpty to use the reusable BitwardenEmptyContent component, reducing code duplication
• Adding comprehensive test coverage for the Archive type empty state

Review Details

Category	Status	Notes
Security	No issues	No authentication, authorization, or data handling changes
Correctness	No issues	Logic correctly sets header, message, and vectorRes for Archive type
Breaking Changes	None	Internal UI update only
Test Coverage	Adequate	New test case added in VaultItemListingDataExtensionsTest.kt for Archive type

Highlights

Good refactoring: The removal of the private GenericNoItems composable in favor of the shared BitwardenEmptyContent component improves code reusability and consistency across the app.

Clean implementation: The when expressions in VaultItemListingDataExtensions.kt follow the established pattern for differentiating Archive type from other vault listing types.

---

Reviewed by Claude Code at commit c058a02

[github-actions]

Checkmarx One – Scan Summary & Details – 6188a49d-00ad-48cc-9631-316e9546a1f4

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

❌ Patch coverage is 87.09677% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.46%. Comparing base (98ba169) to head (c058a02).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...vault/feature/itemlisting/VaultItemListingEmpty.kt	33.33%	0 Missing and 2 partials ⚠️
...itemlisting/util/VaultItemListingDataExtensions.kt	92.85%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6369   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files         764      764           
  Lines       54881    54893   +12     
  Branches     7930     7948   +18     
=======================================
+ Hits        46902    46914   +12     
+ Misses       5226     5223    -3     
- Partials     2753     2756    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[david-livefront]

Thanks @SaintPatrck