Skip to content

PM-30897: Add archive and unarchive button on Edit Cipher Screen#6372

Merged
david-livefront merged 1 commit intomainfrom
PM-30897-archive-button
Jan 16, 2026
Merged

PM-30897: Add archive and unarchive button on Edit Cipher Screen#6372
david-livefront merged 1 commit intomainfrom
PM-30897-archive-button

Conversation

@david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Jan 15, 2026

🎟️ Tracking

PM-30897

📔 Objective

This PR adds the Archive and Unarchive buttons to the Edit Item Screen including the appropriate flows associated with that button.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@david-livefront david-livefront requested a review from a team as a code owner January 15, 2026 21:44
@github-actions github-actions bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:misc Change Type - ¯\_(ツ)_/¯ labels Jan 15, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

Logo
Checkmarx One – Scan Summary & Detailse287a249-599d-4807-9719-967c5f1c52b5

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 91.79104% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.47%. Comparing base (757f444) to head (3fd32f4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../ui/vault/feature/addedit/VaultAddEditViewModel.kt 89.21% 0 Missing and 11 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6372      +/-   ##
==========================================
+ Coverage   85.46%   85.47%   +0.01%     
==========================================
  Files         764      764              
  Lines       54893    55027     +134     
  Branches     7948     7976      +28     
==========================================
+ Hits        46914    47037     +123     
  Misses       5223     5223              
- Partials     2756     2767      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront david-livefront force-pushed the PM-30897-archive-button branch from a4faa5c to 3fd32f4 Compare January 16, 2026 16:48
Copy link
Contributor

@SaintPatrck SaintPatrck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Jan 16, 2026
Merged via the queue into main with commit 759e056 Jan 16, 2026
16 checks passed
@david-livefront david-livefront deleted the PM-30897-archive-button branch January 16, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:misc Change Type - ¯\_(ツ)_/¯

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants