Skip to content

Move Vault Listing Dialog clicks to VaultItemListingHandlers#6375

Merged
david-livefront merged 1 commit intomainfrom
update-vault-listing-clicks
Jan 16, 2026
Merged

Move Vault Listing Dialog clicks to VaultItemListingHandlers#6375
david-livefront merged 1 commit intomainfrom
update-vault-listing-clicks

Conversation

@david-livefront
Copy link
Collaborator

🎟️ Tracking

N/A

📔 Objective

This PR cleans up the click events in the VaultItemListingScreen with the VaultItemListingHandlers.

No functional changes were made in this PR.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@david-livefront david-livefront requested a review from a team as a code owner January 16, 2026 19:15
@github-actions github-actions bot added app:password-manager Bitwarden Password Manager app context t:misc Change Type - ¯\_(ツ)_/¯ labels Jan 16, 2026
@david-livefront david-livefront added the ai-review Request a Claude code review label Jan 16, 2026
@claude
Copy link
Contributor

claude bot commented Jan 16, 2026

Claude finished @david-livefront's task in 1m 43s —— View job


Code Review: Move Vault Listing Dialog clicks to VaultItemListingHandlers

Result: APPROVED

Summary

This PR refactors dialog-related click handlers from inline lambdas in VaultItemListingScreen to the centralized VaultItemListingHandlers class. The change reduces parameter complexity and improves code organization without any functional changes.

Changes Reviewed

File Change
VaultItemListingHandlers.kt Added 13 new handler functions for dialog actions
VaultItemListingScreen.kt Simplified VaultItemListingDialogs call from 14 callback parameters to 1 handler object
VaultItemListingContent.kt Simplified from 5 callback parameters to 1 handler object

Analysis

  • Security: No concerns - pure refactoring with no business logic changes
  • Correctness: Handler implementations correctly map to the same VaultItemListingsAction dispatches
  • Pattern Compliance: Follows established handler patterns used throughout the codebase (e.g., VaultItemListingUserVerificationHandlers, VaultCommonItemTypeHandlers)
  • Test Impact: Existing tests should be unaffected as they interact via ViewModel actions

No issues found.


Reviewed via Claude Code

SaintPatrck
SaintPatrck previously approved these changes Jan 16, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

Logo
Checkmarx One – Scan Summary & Details789b57a8-4863-4782-ab35-46ffdd47257b

Great job! No new security vulnerabilities introduced in this pull request

@david-livefront david-livefront force-pushed the update-vault-listing-clicks branch from a58c090 to ad5062b Compare January 16, 2026 19:21
@github-actions github-actions bot removed the ai-review Request a Claude code review label Jan 16, 2026
@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Jan 16, 2026
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 96.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.50%. Comparing base (759e056) to head (ad5062b).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ult/feature/itemlisting/VaultItemListingContent.kt 71.42% 0 Missing and 2 partials ⚠️
...ault/feature/itemlisting/VaultItemListingScreen.kt 94.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6375      +/-   ##
==========================================
+ Coverage   85.47%   85.50%   +0.02%     
==========================================
  Files         764      764              
  Lines       55027    55037      +10     
  Branches     7976     7965      -11     
==========================================
+ Hits        47037    47058      +21     
  Misses       5223     5223              
+ Partials     2767     2756      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue into main with commit 27a0f51 Jan 16, 2026
16 checks passed
@david-livefront david-livefront deleted the update-vault-listing-clicks branch January 16, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:password-manager Bitwarden Password Manager app context t:misc Change Type - ¯\_(ツ)_/¯

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants