Add comprehensive tests for Unlock feature

[SaintPatrck]

🎟️ Tracking

Test coverage improvements for critical unlock/authentication functionality.

📔 Objective

This PR adds comprehensive test coverage for the Unlock feature, which serves as the authentication gate for the Authenticator application. The unlock flow is security-critical and requires thorough testing to ensure correct behavior across all user scenarios.

Test Coverage:

• UnlockViewModel: Complete test suite covering authentication state management, biometric flows, PIN validation, and error handling
• UnlockScreen: UI test coverage for Compose screen rendering, user interactions, and state-driven UI updates

Critical Scenarios Tested:

• Biometric authentication success/failure flows
• PIN entry validation and verification
• Account unlock state transitions
• Error handling and user feedback
• Edge cases: empty PIN, biometric unavailable, authentication timeouts

The unlock screen is the first security barrier users encounter. These tests ensure authentication mechanisms function correctly, handle failures gracefully, and maintain proper security posture across all scenarios.

📸 Screenshots

N/A - Test-only changes

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

🤖 Generated with Claude Code

[github-actions]

Checkmarx One – Scan Summary & Details – 80a2258f-d1e4-41ca-999c-db0dfb3b70a4

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.30%. Comparing base (a2ec99f) to head (e92447d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6426      +/-   ##
==========================================
+ Coverage   86.05%   86.30%   +0.24%     
==========================================
  Files         777      780       +3     
  Lines       56245    56374     +129     
  Branches     8140     8140              
==========================================
+ Hits        48400    48651     +251     
+ Misses       5011     4884     -127     
- Partials     2834     2839       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[claude]

Claude finished @SaintPatrck's task in 2m 19s —— View job

---

Code Review Summary

Status: Approved

PR Overview

This PR adds comprehensive test coverage for the Unlock feature, a security-critical authentication flow in the Authenticator application.

File	Lines	Tests
UnlockViewModelTest.kt	488	17
UnlockScreenTest.kt	286	13

Review Assessment

All previous review comments have been addressed:

• Complete state assertions implemented (not individual field assertions)
• Dialog content verified within dialog context using hasAnyAncestor(isDialog())
• createViewModel uses nullable state pattern instead of passing SavedStateHandle directly
• Unused variable initialization removed
• Loading states explicitly asserted rather than skipped

Code Quality:

• Follows established Bitwarden testing patterns (AuthenticatorComposeTest, BaseViewModelTest)
• Proper use of Turbine for Flow testing with explicit state verification
• Good callback capture pattern for BiometricsManager interactions
• Comprehensive coverage of security-critical scenarios:
  • Biometric authentication success/failure/lockout
  • Biometric decoding errors with clearBiometrics() verification
  • Dialog state management
  • Navigation events

No issues identified - The test code is well-structured and follows project conventions.

Verdict

Ready for merge.