Skip to content

PM-31926: Add Autofill reminder for Vivaldi browser#6494

Merged
david-livefront merged 1 commit intomainfrom
PM-31926-vivaldi-autofill-reminder
Feb 9, 2026
Merged

PM-31926: Add Autofill reminder for Vivaldi browser#6494
david-livefront merged 1 commit intomainfrom
PM-31926-vivaldi-autofill-reminder

Conversation

@david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Feb 9, 2026

🎟️ Tracking

PM-31926

📔 Objective

This PR adds the User Vivaldi autofill integration switch to remind users of browser specific autofill integrations.

This is identical to the UI we provide for Chrome and Brave already.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@david-livefront david-livefront requested a review from a team as a code owner February 9, 2026 17:25
@github-actions github-actions bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context labels Feb 9, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

Logo
Checkmarx One – Scan Summary & Detailsde8d9109-d61b-47c7-8d37-c793b0be884f

Great job! No new security vulnerabilities introduced in this pull request

@david-livefront david-livefront force-pushed the PM-31926-vivaldi-autofill-reminder branch from c5efcaa to 5a5e18f Compare February 9, 2026 17:36
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.36%. Comparing base (594cb50) to head (5a5e18f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6494   +/-   ##
=======================================
  Coverage   86.36%   86.36%           
=======================================
  Files         767      767           
  Lines       56035    56042    +7     
  Branches     8151     8152    +1     
=======================================
+ Hits        48395    48402    +7     
  Misses       4800     4800           
  Partials     2840     2840           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront david-livefront added t:feature Change Type - Feature Development ai-review Request a Claude code review labels Feb 9, 2026
@claude
Copy link
Contributor

claude bot commented Feb 9, 2026

Claude finished @david-livefront's task in 1m 15s —— View job


Code Review: PM-31926 - Add Autofill reminder for Vivaldi browser

Result: APPROVED

This PR correctly adds Vivaldi browser support for the third-party autofill integration reminder feature, following the established patterns exactly as implemented for Brave and Chrome browsers.

Summary

Category Assessment
Security No concerns
Correctness Follows existing patterns consistently
Breaking Changes None - purely additive
Test Coverage 100% on modified lines

Changes Reviewed

  • Data Layer: BrowserPackage, BrowserThirdPartyAutoFillData, BrowserThirdPartyAutofillStatus - Correct package name (com.vivaldi.browser) and proper integration into status tracking
  • Manager Layer: BrowserThirdPartyAutofillManager, BrowserThirdPartyAutofillManagerImpl, AutofillActivityManagerImpl - Consistent implementation following existing browser patterns
  • UI Layer: BrowserAutofillSettingsOption.VivaldiStable, extension function mapping, string resource - Clean sealed class implementation matching existing options
  • Tests: All 7 test files properly updated with Vivaldi status data

Verification

The implementation is identical in structure to the existing Brave and Chrome integrations, which demonstrates good adherence to the codebase's established patterns.


Automated review by Claude Code

@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Feb 9, 2026
Merged via the queue into main with commit c0907b8 Feb 9, 2026
19 checks passed
@david-livefront david-livefront deleted the PM-31926-vivaldi-autofill-reminder branch February 9, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants