Skip to content

[PM-32658] Add skill routing to CLAUDE.md Quick Reference#6574

Merged
SaintPatrck merged 2 commits intomainfrom
claude/add-core-conventions-skill
Feb 27, 2026
Merged

[PM-32658] Add skill routing to CLAUDE.md Quick Reference#6574
SaintPatrck merged 2 commits intomainfrom
claude/add-core-conventions-skill

Conversation

@SaintPatrck
Copy link
Contributor

@SaintPatrck SaintPatrck commented Feb 24, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-32658

📔 Objective

Add explicit skill routing to CLAUDE.md Quick Reference section, directing Claude to use implementing-android-code before writing code and testing-android-code before writing tests. Also adds a code style pointer to docs/STYLE_AND_BEST_PRACTICES.md.

@github-actions github-actions bot added the t:llm Change Type - LLM related change (e.g. CLAUDE.md files) label Feb 24, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026

Logo
Checkmarx One – Scan Summary & Detailsb9165e2e-0470-4b92-a568-06b1a4b289a5

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.41%. Comparing base (ed1abca) to head (09a5436).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6574   +/-   ##
=======================================
  Coverage   86.41%   86.41%           
=======================================
  Files         800      800           
  Lines       57149    57149           
  Branches     8262     8262           
=======================================
  Hits        49383    49383           
  Misses       4900     4900           
  Partials     2866     2866           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SaintPatrck SaintPatrck added the ai-review Request a Claude code review label Feb 24, 2026
@claude
Copy link
Contributor

claude bot commented Feb 24, 2026

Claude finished @SaintPatrck's task in 1m 32s —— View job


Re-Review Summary

Scope: Commit 09a5436 (since last review) -- reverted the core-conventions skill file and inlined conventions back into CLAUDE.md with explicit skill routing in Quick Reference.

Net PR change: 3 documentation lines added to .claude/CLAUDE.md Quick Reference section, adding skill routing for code style, implementation, and testing guidance.

Previous finding: The SUGGESTED comment about a missing version field in .claude/skills/core-conventions/SKILL.md is now moot -- that file was deleted in the latest commit.

No new issues found. This is a clean, documentation-only change. Approving.

@SaintPatrck SaintPatrck force-pushed the claude/add-build-test-verify-skill branch from 0f3d440 to 7cc2ce6 Compare February 26, 2026 20:21
@SaintPatrck SaintPatrck force-pushed the claude/add-core-conventions-skill branch from 9847de7 to 8dc7a8c Compare February 26, 2026 21:13
@SaintPatrck SaintPatrck force-pushed the claude/add-core-conventions-skill branch from 8dc7a8c to 7bf1457 Compare February 27, 2026 16:44
Base automatically changed from claude/add-build-test-verify-skill to main February 27, 2026 17:09
@SaintPatrck SaintPatrck changed the title [PM-32658] Add core-conventions skill and extract style/anti-pattern sections [PM-32658] Add skill routing to CLAUDE.md Quick Reference Feb 27, 2026
SaintPatrck and others added 2 commits February 27, 2026 12:24
Co-Authored-By: Claude <noreply@anthropic.com>
…ck Reference

The core-conventions skill duplicated 52% of its content with
implementing-android-code and other skills. Restoring conventions
inline in CLAUDE.md ensures they are always available without
depending on skill triggering. Added explicit skill routing in
Quick Reference for code style, implementation, and testing.
@SaintPatrck SaintPatrck force-pushed the claude/add-core-conventions-skill branch from 0e6880c to 09a5436 Compare February 27, 2026 17:24
@SaintPatrck SaintPatrck marked this pull request as ready for review February 27, 2026 17:53
@SaintPatrck SaintPatrck requested a review from a team as a code owner February 27, 2026 17:53
@SaintPatrck
Copy link
Contributor Author

Thanks @theMickster

@SaintPatrck SaintPatrck added this pull request to the merge queue Feb 27, 2026
Merged via the queue into main with commit 1f9390a Feb 27, 2026
23 checks passed
@SaintPatrck SaintPatrck deleted the claude/add-core-conventions-skill branch February 27, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:llm Change Type - LLM related change (e.g. CLAUDE.md files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants