Skip to content

Remove unnecessary opt-in annotations#6581

Merged
david-livefront merged 1 commit intomainfrom
minor-cleanup
Feb 25, 2026
Merged

Remove unnecessary opt-in annotations#6581
david-livefront merged 1 commit intomainfrom
minor-cleanup

Conversation

@david-livefront
Copy link
Collaborator

🎟️ Tracking

N/A

📔 Objective

This PR removes som opt-in annotations that are no longer needed from the codebase.

@david-livefront david-livefront requested a review from a team as a code owner February 25, 2026 16:15
@david-livefront david-livefront added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:tech-debt Change Type - Tech debt ai-review Request a Claude code review labels Feb 25, 2026
@github-actions github-actions bot removed the t:tech-debt Change Type - Tech debt label Feb 25, 2026
@claude
Copy link
Contributor

claude bot commented Feb 25, 2026

Claude finished @david-livefront's task in 1m 15s —— View job


Summary

Clean PR. Two files changed, all changes are correct.

Changes reviewed:

  • CallingAppInfoExtensions.kt: Removed @OptIn(ExperimentalStdlibApi::class) from getSignatureFingerprintAsHexString() — the Byte.toHexString() API is stable since Kotlin 1.9 and the project is on Kotlin 2.3.10.
  • StringExtensions.kt: Removed @OptIn(ExperimentalStdlibApi::class) from toHexColorRepresentation() for the same reason; replaced unused exception variable e with _ in toHostOrPathOrNull() per Kotlin convention.

No remaining ExperimentalStdlibApi references exist in the codebase — cleanup is complete.

No issues found.

🤖 Generated with Claude Code

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details8085ab06-edd0-4b80-a566-6a0b2e61f0ea

Great job! No new security vulnerabilities introduced in this pull request

@david-livefront david-livefront added the t:tech-debt Change Type - Tech debt label Feb 25, 2026
@david-livefront david-livefront added this pull request to the merge queue Feb 25, 2026
@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.38%. Comparing base (7b1b519) to head (a977a4e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6581      +/-   ##
==========================================
- Coverage   86.40%   86.38%   -0.03%     
==========================================
  Files         798      799       +1     
  Lines       57018    57106      +88     
  Branches     8258     8258              
==========================================
+ Hits        49266    49330      +64     
- Misses       4887     4911      +24     
  Partials     2865     2865              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 25, 2026
@david-livefront david-livefront added this pull request to the merge queue Feb 25, 2026
@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

Merged via the queue into main with commit 4ca79bb Feb 25, 2026
21 of 23 checks passed
@david-livefront david-livefront deleted the minor-cleanup branch February 25, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants