Skip to content

[PM-32751] ci: Fix version name output in run summary#6585

Merged
vvolkgang merged 3 commits intomainfrom
vvolkgang/fix-version
Feb 26, 2026
Merged

[PM-32751] ci: Fix version name output in run summary#6585
vvolkgang merged 3 commits intomainfrom
vvolkgang/fix-version

Conversation

@vvolkgang
Copy link
Member

🎟️ Tracking

PM-32751

📔 Objective

While testing other work I noticed the build workflows were unintentionally listing most of the content of libs.versions.toml. Took the time to move this bit to a script so it can be reused in other places, mitigating regexp differences between them.

@vvolkgang vvolkgang added the ai-review Request a Claude code review label Feb 25, 2026
@github-actions github-actions bot added the t:ci Change Type - Updates to automated workflows label Feb 25, 2026
@claude
Copy link
Contributor

claude bot commented Feb 25, 2026

Claude finished @vvolkgang's task in 1m 25s —— View job


Pull Request Review: PM-32751 ci: Fix version name output in run summary

Overview

This PR extracts duplicated version-increment logic from three build workflows (build.yml, build-authenticator.yml, build-testharness.yml) into a shared shell script at .github/scripts/set-build-version.sh. It also consolidates the regex used for parsing the version name from the TOML file and adds GITHUB_STEP_SUMMARY output to jobs that were previously missing it.

Change type: CI/infrastructure refactoring and bug fix
Risk level: Low (CI-only changes, no application code affected)

Findings

All findings from the initial review have been resolved:

Severity File Description Status
❌ Critical .github/scripts/set-build-version.sh Missing execute permission (100644 vs 100755) ✅ Fixed in b0a78cf

Notes

  • The consolidation of the version regex from (.+) (testharness) to ([^"]+) (shared script) is a correctness improvement.
  • Moving the fallback logic from bash ${VERSION_CODE:-$GITHUB_RUN_NUMBER} to the YAML expression ${{ ... || github.run_number }} is functionally equivalent.
  • The set -euo pipefail and GITHUB_STEP_SUMMARY guard are both good practices.
  • The publish_standard job in build.yml now gains step summary output it previously lacked -- a nice side effect of the consolidation.

No remaining issues. This PR looks good to merge.

@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.47%. Comparing base (1abb640) to head (151ec2f).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6585   +/-   ##
=======================================
  Coverage   86.47%   86.47%           
=======================================
  Files         795      795           
  Lines       56930    56930           
  Branches     8259     8259           
=======================================
  Hits        49230    49230           
  Misses       4835     4835           
  Partials     2865     2865           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

Logo
Checkmarx One – Scan Summary & Details19eec064-c560-4d9b-b6cf-9712f31f6c3b

Great job! No new security vulnerabilities introduced in this pull request

@vvolkgang vvolkgang removed the ai-review Request a Claude code review label Feb 25, 2026
@vvolkgang vvolkgang marked this pull request as ready for review February 25, 2026 21:33
@vvolkgang vvolkgang requested a review from a team as a code owner February 25, 2026 21:33
@vvolkgang vvolkgang enabled auto-merge February 26, 2026 14:52
@vvolkgang vvolkgang added this pull request to the merge queue Feb 26, 2026
Merged via the queue into main with commit c7d173c Feb 26, 2026
17 checks passed
@vvolkgang vvolkgang deleted the vvolkgang/fix-version branch February 26, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:ci Change Type - Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants