Move FakeLifecycle to core module#6608
Merged
david-livefront merged 1 commit intomainfrom Mar 2, 2026
Merged
Conversation
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6608 +/- ##
==========================================
- Coverage 85.79% 85.26% -0.54%
==========================================
Files 933 937 +4
Lines 59527 59549 +22
Branches 8328 8332 +4
==========================================
- Hits 51071 50773 -298
- Misses 5557 5885 +328
+ Partials 2899 2891 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SaintPatrck
approved these changes
Mar 2, 2026
Collaborator
Author
|
Thanks @SaintPatrck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🎟️ Tracking
N/A
📔 Objective
This PR moves the
FakeLifecycleandFakeLifecycleOwnerto thecoremodule so it can be shared across all tests that need it.