Skip to content

Move FakeLifecycle to core module#6608

Merged
david-livefront merged 1 commit intomainfrom
common-fake-lifecycle
Mar 2, 2026
Merged

Move FakeLifecycle to core module#6608
david-livefront merged 1 commit intomainfrom
common-fake-lifecycle

Conversation

@david-livefront
Copy link
Collaborator

🎟️ Tracking

N/A

📔 Objective

This PR moves the FakeLifecycle and FakeLifecycleOwner to the core module so it can be shared across all tests that need it.

@david-livefront david-livefront requested a review from a team as a code owner March 2, 2026 17:32
@david-livefront david-livefront added the t:tech-debt Change Type - Tech debt label Mar 2, 2026
@github-actions github-actions bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context and removed t:tech-debt Change Type - Tech debt labels Mar 2, 2026
@david-livefront david-livefront added the t:tech-debt Change Type - Tech debt label Mar 2, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

Logo
Checkmarx One – Scan Summary & Details1f065666-ca03-4be7-97fc-eb00f7bcdab1

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.26%. Comparing base (3b081fa) to head (2f03017).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6608      +/-   ##
==========================================
- Coverage   85.79%   85.26%   -0.54%     
==========================================
  Files         933      937       +4     
  Lines       59527    59549      +22     
  Branches     8328     8332       +4     
==========================================
- Hits        51071    50773     -298     
- Misses       5557     5885     +328     
+ Partials     2899     2891       -8     
Flag Coverage Δ
app-data 17.24% <ø> (-0.57%) ⬇️
app-ui-auth-tools 21.12% <ø> (-0.15%) ⬇️
app-ui-platform 15.76% <ø> (-0.01%) ⬇️
app-ui-vault 26.53% <ø> (+<0.01%) ⬆️
authenticator 6.49% <ø> (+0.03%) ⬆️
lib-core-network-bridge 4.32% <ø> (+0.02%) ⬆️
lib-data-ui 0.90% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Mar 2, 2026
Merged via the queue into main with commit 836233f Mar 2, 2026
27 of 28 checks passed
@david-livefront david-livefront deleted the common-fake-lifecycle branch March 2, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants