[PM-33515] feat: Render premium upgrade banner in Vault UI#6698
[PM-33515] feat: Render premium upgrade banner in Vault UI#6698SaintPatrck merged 5 commits intomainfrom
Conversation
|
Claude finished @SaintPatrck's task in 1m 43s —— View job Code Review: PM-33515 Render premium upgrade banner in Vault UI
Overall Assessment: APPROVE Reviewed 16 changed files across 5 commits implementing the premium upgrade banner in the Vault UI, a debug menu reset option, and standardized "Premium" casing. The implementation is clean and follows established codebase patterns:
All previously flagged issues (build failure from removed |
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6698 +/- ##
==========================================
+ Coverage 85.67% 85.88% +0.20%
==========================================
Files 852 806 -46
Lines 59107 57460 -1647
Branches 8435 8398 -37
==========================================
- Hits 50641 49349 -1292
+ Misses 5524 5183 -341
+ Partials 2942 2928 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3ab40a1 to
ad245e9
Compare
b8516f2 to
1c4e0eb
Compare
1c4e0eb to
bc8450a
Compare
bc8450a to
b84a8b5
Compare
| <string name="archiving_items_is_a_premium_feature">Archiving items is a Premium feature. Your current plan does not include access to this feature.</string> | ||
| <string name="upgrade_to_premium">Upgrade to premium</string> | ||
| <string name="upgrade_to_premium" comment="Sentence case version used in dialogs">Upgrade to premium</string> | ||
| <string name="upgrade_to_premium_title" comment="Title case version used in action cards and screen title">Upgrade to Premium</string> |
There was a problem hiding this comment.
Why is it not capital P Premium all the time?
There was a problem hiding this comment.
Discussed offline. We will update usages of "premium" to "Premium" as a separate task.
7d2ed50 to
cdd0aae
Compare
cdd0aae to
bd648d6
Compare

🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-33515
📔 Objective
Renders the premium upgrade
BitwardenActionCardin the Vault screen when the user is eligible for a premium upgrade. Replaces the PM-33514 placeholder with a full composable implementation including:actionCardClickhandler)dismissActionCardClickhandler)Screen tests cover banner display, CTA click, and dismiss interactions.
Debug Menu
Adds a debug menu option to reset the premium upgrade banner dismiss state, enabling QA to re-test the banner without clearing app data. Also organizes the debug menu with section headers for "Cookies" and "Premium".
📸 Screenshots