Skip to content

misc: Update BitwardenButtonData for more usability#6704

Merged
david-livefront merged 1 commit intomainfrom
improve-button-model
Mar 20, 2026
Merged

misc: Update BitwardenButtonData for more usability#6704
david-livefront merged 1 commit intomainfrom
improve-button-model

Conversation

@david-livefront
Copy link
Copy Markdown
Collaborator

🎟️ Tracking

N/A

📔 Objective

Update the BitwardenButtonData to increase flexibility.

@david-livefront david-livefront requested a review from a team as a code owner March 20, 2026 18:46
@david-livefront david-livefront added the ai-review Request a Claude code review label Mar 20, 2026
@david-livefront david-livefront changed the title Update BitwardenButtonData for more usability misc: Update BitwardenButtonData for more usability Mar 20, 2026
@github-actions github-actions bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:misc Change Type - ¯\_(ツ)_/¯ labels Mar 20, 2026
@david-livefront david-livefront added t:misc Change Type - ¯\_(ツ)_/¯ and removed t:misc Change Type - ¯\_(ツ)_/¯ labels Mar 20, 2026
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Mar 20, 2026

Claude finished @david-livefront's task in 1m 48s —— View job


Re-review: Update BitwardenButtonData for more usability

  • Verify the cardInsets fix
  • Run full code review
  • Post findings

Summary

The previous finding (inconsistent default cardInsets in BitwardenOutlinedButton) has been resolved — the new overload now correctly defaults to PaddingValues(horizontal = 16.dp, vertical = 6.dp), matching the original overload.

No new issues found. The PR is clean — convenience overloads are consistent across all three button types, and call-site simplifications are straightforward.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.40%. Comparing base (6cf15fb) to head (db18e3c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6704   +/-   ##
=======================================
  Coverage   86.40%   86.40%           
=======================================
  Files         793      793           
  Lines       57069    57069           
  Branches     8394     8394           
=======================================
  Hits        49308    49308           
  Misses       4833     4833           
  Partials     2928     2928           
Flag Coverage Δ
app-data 17.74% <ø> (ø)
app-ui-auth-tools 20.77% <ø> (ø)
app-ui-platform 15.03% <ø> (ø)
app-ui-vault 25.85% <ø> (ø)
authenticator 6.64% <ø> (ø)
lib-core-network-bridge 4.29% <ø> (ø)
lib-data-ui 0.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 20, 2026

Logo
Checkmarx One – Scan Summary & Detailsc1291b17-26c9-48ea-acbc-71f41399ffce

Great job! No new security vulnerabilities introduced in this pull request

@david-livefront
Copy link
Copy Markdown
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Mar 20, 2026
Merged via the queue into main with commit 6c7348e Mar 20, 2026
38 of 39 checks passed
@david-livefront david-livefront deleted the improve-button-model branch March 20, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:misc Change Type - ¯\_(ツ)_/¯

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants