chore: Create common UI elements for VaultItemScreen#6746
chore: Create common UI elements for VaultItemScreen#6746david-livefront merged 1 commit intomainfrom
Conversation
|
Claude finished @david-livefront's task in 4m 2s —— View job Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR extracts duplicated UI code from five cipher-type content screens (Login, Card, Identity, SecureNote, SshKey) into four shared Code Review DetailsNo findings. The extraction is a faithful 1:1 mapping of the original inline code, type migrations are properly handled at all call sites (including |
| @Suppress("LongMethod") | ||
| @Composable | ||
| fun AttachmentItemContent( | ||
| fun VaultItemAttachment( |
There was a problem hiding this comment.
This rename was to match the pattern of the of elements
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6746 +/- ##
==========================================
+ Coverage 84.75% 85.49% +0.74%
==========================================
Files 944 861 -83
Lines 60715 59555 -1160
Branches 8569 8530 -39
==========================================
- Hits 51456 50915 -541
+ Misses 6293 5683 -610
+ Partials 2966 2957 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1ebf004 to
86486cb
Compare
86486cb to
3c40654
Compare
| .standardHorizontalMargin() | ||
| .padding(horizontal = 12.dp) | ||
| .animateItem() | ||
| .testTag(tag = "CipherItemCreated"), |
There was a problem hiding this comment.
A couple of these tags have been updated to be common. I have alerted the automation team and they are OK with the changes.
3c40654 to
7143952
Compare
|
New Issues (129)Checkmarx found the following issues in this Pull Request
|
|
Thanks @SaintPatrck |


🎟️ Tracking
N/A
📔 Objective
This PR creates several common reusable UI elements for the
VaultItemScreento ensure a consistent UI.This idea was sparked because there was recently a bug on the Identity UI that did not exist in the other cipher types. Making the code common will help up keep everything consistent.