PM-34499: bug: Add appropriate external link callouts for attachments#6752
Merged
david-livefront merged 1 commit intomainfrom Apr 1, 2026
Merged
PM-34499: bug: Add appropriate external link callouts for attachments#6752david-livefront merged 1 commit intomainfrom
david-livefront merged 1 commit intomainfrom
Conversation
github-actions
bot
added
app:password-manager
Contributor
|
Claude finished @david-livefront's task in 1m 28s —— View job 🤖 Bitwarden Claude Code ReviewOverall Assessment: ✅ APPROVE This is a clean, well-structured PR. The previous typo finding ( Summary of changes:
No findings — all previous review comments have been addressed. |
david-livefront
added
t:bug
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| isExternalLink: Boolean = false, | ||
| contentColor: Color = BitwardenTheme.colorScheme.icon.primary, | ||
| ) { | ||
| val formatedContentDescription = if (isExternalLink) { |
Contributor
There was a problem hiding this comment.
♻️ DEBT: Typo in variable name — formated should be formatted to match codebase convention
Details and fix
Every other component in the codebase uses formattedContentDescription (e.g., BitwardenOutlinedButton, BitwardenFilledButton, BitwardenTextRow). This should be consistent.
Suggested change
| val formatedContentDescription = if (isExternalLink) { | |
| val formattedContentDescription = if (isExternalLink) { |
Contributor
There was a problem hiding this comment.
Claude finished @david-livefront's task in 41s —— View job
Typo fix verified
- Verify the typo fix in
BitwardenStandardIconButton.kt
Confirmed — formattedContentDescription is now used consistently on lines 73 and 83. Looks good, thanks for the quick fix! 👍
| IconButton( | ||
| modifier = modifier.semantics(mergeDescendants = true) { | ||
| this.contentDescription = contentDescription | ||
| this.contentDescription = formatedContentDescription |
Contributor
There was a problem hiding this comment.
♻️ DEBT: Second occurrence of the typo — update to match the renamed variable.
Suggested change
| this.contentDescription = formatedContentDescription | |
| this.contentDescription = formattedContentDescription |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6752 +/- ##
==========================================
- Coverage 85.92% 85.70% -0.22%
==========================================
Files 846 817 -29
Lines 59070 58080 -990
Branches 8513 8504 -9
==========================================
- Hits 50754 49776 -978
+ Misses 5364 5354 -10
+ Partials 2952 2950 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
New Issues (129)Checkmarx found the following issues in this Pull Request
|
david-livefront
force-pushed
the
PM-34499-attachment-external-link
branch
from
713c3fd to
a322cc4
Compare
SaintPatrck
approved these changes
Apr 1, 2026
Collaborator
Author
|
Thanks @SaintPatrck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-34499
📔 Objective
This PR adds accessibility callouts for external links in the Attachments UI.