Fix to set latest on PWM release notes only#6806
Closed
mpbw2 wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6806 +/- ##
==========================================
- Coverage 85.41% 85.10% -0.31%
==========================================
Files 871 911 +40
Lines 60064 60493 +429
Branches 8613 8624 +11
==========================================
+ Hits 51304 51483 +179
- Misses 5775 6019 +244
- Partials 2985 2991 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Contributor
Author
|
This is only an issue when setting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📔 Objective
Occasionally Authenticator is marked as 'Latest' when the release notes are taken out of draft, which shouldn't happen (we only set
Lateston PWM). This fixes that.Reasoning per claude:
gh release editwithout--latestmay send amake_latest:truedefault to the GitHub API, which would override the--latest=falseset during draft creation. By explicitly forwarding the sameis_latest_releasevalue, the Authenticator draft release will consistently remainmake_latest=false.