Skip to content

chore: Update to latest Protobuf plugin and start using new DSL#6811

Merged
david-livefront merged 1 commit intomainfrom
update-protobuf-plugin
Apr 20, 2026
Merged

chore: Update to latest Protobuf plugin and start using new DSL#6811
david-livefront merged 1 commit intomainfrom
update-protobuf-plugin

Conversation

@david-livefront
Copy link
Copy Markdown
Collaborator

@david-livefront david-livefront commented Apr 20, 2026

🎟️ Tracking

PM-32078
PM-31921

📔 Objective

This PR updates the Protobuf Gradle Plugin to the latest version (v0.10.0). This was the last dependency blocking us from using the new Gradle 9 DSL, so that has been enabled as well.

Release Notes!

@david-livefront david-livefront requested a review from a team as a code owner April 20, 2026 14:35
@david-livefront david-livefront added the ai-review-vnext Request a Claude code review using the vNext workflow label Apr 20, 2026
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:tech-debt Change Type - Tech debt t:deps Change Type - Dependencies labels Apr 20, 2026
@david-livefront david-livefront changed the title Update to latest Protobuf plugin and start using new DSL deps: Update to latest Protobuf plugin and start using new DSL Apr 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR bumps the Protobuf Gradle Plugin from 0.9.6 to 0.10.0 in gradle/libs.versions.toml and removes the android.newDsl=false override in gradle.properties to adopt the new Gradle 9 DSL. The plugin was already approved and in use; the version bump is a minor update with release notes linked in the description. No remaining references to the removed newDsl flag exist, and the existing protobuf { ... } configuration in authenticator/build.gradle.kts remains compatible.

Code Review Details

No blocking findings.

Dependency Changes

Package Change Ecosystem
com.google.protobuf (plugin) 0.9.6 → 0.10.0 Gradle

@david-livefront david-livefront removed the t:deps Change Type - Dependencies label Apr 20, 2026
@david-livefront david-livefront changed the title deps: Update to latest Protobuf plugin and start using new DSL chore: Update to latest Protobuf plugin and start using new DSL Apr 20, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.70%. Comparing base (75b87e1) to head (7865ae1).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6811   +/-   ##
=======================================
  Coverage   85.70%   85.70%           
=======================================
  Files         871      871           
  Lines       60198    60198           
  Branches     8629     8629           
=======================================
  Hits        51595    51595           
  Misses       5612     5612           
  Partials     2991     2991           
Flag Coverage Δ
app-data 17.28% <ø> (ø)
app-ui-auth-tools 20.19% <ø> (ø)
app-ui-platform 15.84% <ø> (ø)
app-ui-vault 26.65% <ø> (ø)
authenticator 6.73% <ø> (ø)
lib-core-network-bridge 4.30% <ø> (ø)
lib-data-ui 1.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Details0674e486-6f9a-416f-986b-86cddccdf7fd

Great job! No new security vulnerabilities introduced in this pull request

@david-livefront
Copy link
Copy Markdown
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Apr 20, 2026
Merged via the queue into main with commit 9df39eb Apr 20, 2026
27 of 32 checks passed
@david-livefront david-livefront deleted the update-protobuf-plugin branch April 20, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants