chore: Remove MaxLineLength suppression guidance from testing skill#6813
Conversation
The STOP block primed agents to reach for `@Suppress("MaxLineLength")`
even when not warranted. Detekt runs as a pre-commit hook and already
flags lines that genuinely exceed the 100-char limit, so in-skill
guidance about the suppression is redundant and net-harmful.
SaintPatrck
added
the
ai-review-vnext
github-actions
Bot
added
t:tech-debt
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR removes a two-line Code Review DetailsNo findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6813 +/- ##
=======================================
Coverage 85.81% 85.81%
=======================================
Files 856 856
Lines 59571 59571
Branches 8560 8560
=======================================
Hits 51121 51121
Misses 5499 5499
Partials 2951 2951
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great job! No new security vulnerabilities introduced in this pull request |
3 participants
🎟️ Tracking
No ticket — repo tooling cleanup for the
.claude/Claude Code skill files.📔 Objective
The
testing-android-codeskill contained a prominent STOP block instructing agents when to add@Suppress(\"MaxLineLength\"). In practice this primed agents to reach for the annotation reflexively even on lines well under the 100-char limit.Detekt already runs as a pre-commit hook and flags any line that genuinely exceeds the limit, so in-skill guidance about the suppression is redundant and net-harmful. Removing the block lets detekt serve as the single source of truth.