Skip to content

chore: Remove deprecated code from BitwardenCutCopyTextToolbar#6815

Merged
david-livefront merged 1 commit intomainfrom
fix-deprecations
Apr 22, 2026
Merged

chore: Remove deprecated code from BitwardenCutCopyTextToolbar#6815
david-livefront merged 1 commit intomainfrom
fix-deprecations

Conversation

@david-livefront
Copy link
Copy Markdown
Collaborator

🎟️ Tracking

N/A

📔 Objective

This PR addresses some minor deprecation in the BitwardenCutCopyTextToolbar.

@david-livefront david-livefront requested a review from a team as a code owner April 21, 2026 14:54
@david-livefront david-livefront added the ai-review-vnext Request a Claude code review using the vNext workflow label Apr 21, 2026
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:tech-debt Change Type - Tech debt labels Apr 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed a focused 7-line refactor in BitwardenCutCopyTextToolbar.kt that replaces the deprecated androidx.core.os.persistableBundleOf helper with direct PersistableBundle construction. The replacement is functionally equivalent, preserves the android.content.extra.IS_SENSITIVE flag behavior on the clipboard description, and the class remains annotated with @OmitFromCoverage so no test changes are required. No security, correctness, or breaking-change concerns identified.

Code Review Details

No findings.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.61%. Comparing base (88a80cd) to head (fb8d6f1).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6815      +/-   ##
==========================================
- Coverage   85.93%   85.61%   -0.32%     
==========================================
  Files         828      874      +46     
  Lines       58505    60295    +1790     
  Branches     8550     8589      +39     
==========================================
+ Hits        50275    51623    +1348     
- Misses       5278     5705     +427     
- Partials     2952     2967      +15     
Flag Coverage Δ
app-data 17.03% <ø> (-0.39%) ⬇️
app-ui-auth-tools 20.58% <ø> (+0.22%) ⬆️
app-ui-platform 15.65% <ø> (+0.39%) ⬆️
app-ui-vault 26.65% <ø> (+0.63%) ⬆️
authenticator 6.74% <ø> (+0.02%) ⬆️
lib-core-network-bridge 4.30% <ø> (+0.01%) ⬆️
lib-data-ui 1.04% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Details8c3af428-f93b-4b53-961a-eff19bbc341f

Great job! No new security vulnerabilities introduced in this pull request

@david-livefront
Copy link
Copy Markdown
Collaborator Author

Thanks @aj-rosado

@david-livefront david-livefront added this pull request to the merge queue Apr 22, 2026
Merged via the queue into main with commit 83f8fca Apr 22, 2026
26 of 27 checks passed
@david-livefront david-livefront deleted the fix-deprecations branch April 22, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants