PM-35444: bug: Pass org identifier and email directly into continueKeyConnectorLogin function#6817
Merged
david-livefront merged 1 commit intomainfrom Apr 22, 2026
Conversation
…ectorLogin function
github-actions
Bot
added
the
app:password-manager
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6817 +/- ##
==========================================
- Coverage 85.93% 85.32% -0.61%
==========================================
Files 828 928 +100
Lines 58505 60667 +2162
Branches 8550 8597 +47
==========================================
+ Hits 50275 51766 +1491
- Misses 5278 5935 +657
- Partials 2952 2966 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
david-livefront
commented
Apr 21, 2026
| ?: EnterpriseSignOnState( | ||
| dialogState = null, | ||
| orgIdentifierInput = "", | ||
| emailAddress = savedStateHandle.toEnterpriseSignOnArgs().emailAddress, |
Collaborator
Author
There was a problem hiding this comment.
This was kinda funny, I thought I was going to add the email address to this viewModel but it was already in the args 😄
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
david-livefront
changed the title
SaintPatrck
approved these changes
Apr 21, 2026
Collaborator
Author
|
Thanks @SaintPatrck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-35444
📔 Objective
This PR updates the Key Connector flow to directly pass in the email and organization identifier when completing the login process. This avoids issues where those values are not yet remembered, or worse, they are remembered but with different values.