Chore: Remove the unused register API#6870
Merged
Merged
Conversation
github-actions
Bot
added
app:password-manager
david-livefront
commented
May 4, 2026
| masterPassword: String, | ||
| masterPasswordHint: String?, | ||
| emailVerificationToken: String?, | ||
| emailVerificationToken: String, |
Collaborator
Author
There was a problem hiding this comment.
There is no location in the app that passes in a null emailVerificationToken so the call to identityService.register never actual occurs.
david-livefront
commented
May 4, 2026
| ) | ||
| .flatMap { registerKeyResponse -> | ||
| if (emailVerificationToken == null) { | ||
| // TODO PM-6675: Remove register call and service implementation |
Collaborator
Author
There was a problem hiding this comment.
This ticket was already marked as done
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6870 +/- ##
==========================================
- Coverage 85.55% 85.54% -0.02%
==========================================
Files 840 840
Lines 59753 59728 -25
Branches 8720 8717 -3
==========================================
- Hits 51124 51094 -30
- Misses 5631 5634 +3
- Partials 2998 3000 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
david-livefront
force-pushed
the
remove-unused-register-api
branch
from
d9af7f5 to
1bb28b9
Compare
SaintPatrck
approved these changes
May 4, 2026
Collaborator
Author
|
Thanks @SaintPatrck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
N/A
📔 Objective
This PR removes the
identityService.registerAPI from the app, it it no longer supported and should have been removed when the email verification feature flag was removed.