Skip to content

PM-36474: bug: Ensure shared totp labels do not parse secret#6873

Merged
david-livefront merged 1 commit into
mainfrom
PM-36474-totp-labels
May 5, 2026
Merged

PM-36474: bug: Ensure shared totp labels do not parse secret#6873
david-livefront merged 1 commit into
mainfrom
PM-36474-totp-labels

Conversation

@david-livefront
Copy link
Copy Markdown
Collaborator

@david-livefront david-livefront commented May 5, 2026

🎟️ Tracking

PM-36474

📔 Objective

This PR ensures that we do not parse the totp label as the secret for manually entered codes.

📸 Screenshots

Before After

@david-livefront david-livefront requested a review from a team as a code owner May 5, 2026 16:30
@github-actions github-actions Bot added the app:authenticator Bitwarden Authenticator app context label May 5, 2026
@david-livefront david-livefront changed the title PM-36474: Ensure shared totp labels do not parse secret PM-36474: bug: Ensure shared totp labels do not parse secret May 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.35%. Comparing base (3b1ea1e) to head (828dfd2).

Files with missing lines Patch % Lines
...tor/repository/util/SharedAccountDataExtensions.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6873      +/-   ##
==========================================
- Coverage   85.54%   85.35%   -0.20%     
==========================================
  Files         843      975     +132     
  Lines       60060    62372    +2312     
  Branches     8762     8831      +69     
==========================================
+ Hits        51381    53240    +1859     
- Misses       5666     6096     +430     
- Partials     3013     3036      +23     
Flag Coverage Δ
app-data 17.60% <0.00%> (-0.03%) ⬇️
app-ui-auth-tools 20.43% <0.00%> (+0.32%) ⬆️
app-ui-platform 16.51% <0.00%> (+0.62%) ⬆️
app-ui-vault 26.25% <0.00%> (+0.61%) ⬆️
authenticator 6.60% <0.00%> (+0.02%) ⬆️
lib-core-network-bridge 4.07% <0.00%> (-0.15%) ⬇️
lib-data-ui 0.97% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront david-livefront added the t:bug Change Type - Bug label May 5, 2026
@SaintPatrck SaintPatrck added the ai-review-vnext Request a Claude code review using the vNext workflow label May 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed a one-line conditional fix in SharedAccountDataExtensions.toAuthenticatorItems() that prevents the manually-entered TOTP secret from being incorrectly parsed as the label when the cipher's URI has no scheme. The change is small, targeted, and consistent with the bug described in PM-36474. The before/after screenshots in the PR description demonstrate the expected user-visible fix.

Code Review Details

No actionable findings.

@david-livefront
Copy link
Copy Markdown
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue May 5, 2026
Merged via the queue into main with commit d0401b3 May 5, 2026
29 of 32 checks passed
@david-livefront david-livefront deleted the PM-36474-totp-labels branch May 5, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:authenticator Bitwarden Authenticator app context t:bug Change Type - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants