Skip to content

[PM-32810] feat: Add Bank Account item detail view#6875

Merged
SaintPatrck merged 2 commits intomainfrom
new-item-types/PM-32810_bank-account-view
May 6, 2026
Merged

[PM-32810] feat: Add Bank Account item detail view#6875
SaintPatrck merged 2 commits intomainfrom
new-item-types/PM-32810_bank-account-view

Conversation

@SaintPatrck
Copy link
Copy Markdown
Contributor

@SaintPatrck SaintPatrck commented May 5, 2026

🎟️ Tracking

PM-32810

Stacked child: #6877

📔 Objective

Surface the read-only Bank Account detail screen so existing Bank Account ciphers can be opened from any list and have their fields copied. This PR is the detail-screen slice of the original Bank Account view-only feature; the vault-list, item-listing, and search surfaces follow in the stacked child PR.

📸 Screenshots

Figma: https://www.figma.com/design/WjD06w9dFlA67Ba27d1OSu/Dev-Ready--Bitwarden-Android?node-id=40015437-424812&t=I5hzVA3NUII5Fx6B-4

Actual:
|

@SaintPatrck SaintPatrck added the ai-review-vnext Request a Claude code review using the vNext workflow label May 5, 2026
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:feature Change Type - Feature Development labels May 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Claude Code is reviewing this pull request...

If this comment does not update with results, check the Actions log.

@SaintPatrck SaintPatrck removed the app:authenticator Bitwarden Authenticator app context label May 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

❌ Patch coverage is 97.89227% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.64%. Comparing base (01859be) to head (bfcd3f6).

Files with missing lines Patch % Lines
...warden/ui/vault/feature/item/VaultItemViewModel.kt 94.31% 0 Missing and 5 partials ⚠️
.../vault/feature/item/VaultItemBankAccountContent.kt 99.29% 1 Missing and 1 partial ⚠️
...bitwarden/ui/vault/feature/item/VaultItemScreen.kt 88.88% 0 Missing and 1 partial ⚠️
...ui/vault/feature/item/util/CipherViewExtensions.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6875      +/-   ##
==========================================
+ Coverage   85.42%   85.64%   +0.22%     
==========================================
  Files         843      846       +3     
  Lines       60209    60555     +346     
  Branches     8817     8851      +34     
==========================================
+ Hits        51436    51865     +429     
+ Misses       5755     5656      -99     
- Partials     3018     3034      +16     
Flag Coverage Δ
app-data 17.54% <0.00%> (-0.13%) ⬇️
app-ui-auth-tools 19.91% <0.00%> (-0.15%) ⬇️
app-ui-platform 15.73% <0.00%> (-0.12%) ⬇️
app-ui-vault 26.12% <97.89%> (+0.54%) ⬆️
authenticator 6.52% <0.00%> (-0.02%) ⬇️
lib-core-network-bridge 4.18% <0.00%> (-0.02%) ⬇️
lib-data-ui 1.00% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot added the app:authenticator Bitwarden Authenticator app context label May 5, 2026
@SaintPatrck SaintPatrck added ai-review-vnext Request a Claude code review using the vNext workflow and removed ai-review-vnext Request a Claude code review using the vNext workflow labels May 5, 2026
@SaintPatrck SaintPatrck force-pushed the new-item-types/PM-32810_bank-account-view branch from 2a3ba0c to ee53577 Compare May 6, 2026 14:01
@SaintPatrck SaintPatrck changed the title [PM-32810] feat: Add view-only support for Bank Account item type [PM-32810] feat: Add Bank Account item detail view May 6, 2026
@SaintPatrck SaintPatrck marked this pull request as ready for review May 6, 2026 15:08
@SaintPatrck SaintPatrck requested review from a team and david-livefront as code owners May 6, 2026 15:08
Surfaces the read-only Bank Account detail screen so existing Bank
Account ciphers can be viewed and their fields copied.
@SaintPatrck SaintPatrck force-pushed the new-item-types/PM-32810_bank-account-view branch from 3797c7d to bfcd3f6 Compare May 6, 2026 15:38
@SaintPatrck SaintPatrck enabled auto-merge May 6, 2026 15:39
@SaintPatrck SaintPatrck added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit 38c4da2 May 6, 2026
24 of 25 checks passed
@SaintPatrck SaintPatrck deleted the new-item-types/PM-32810_bank-account-view branch May 6, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants