Use string resource for button label#6897
Merged
david-livefront merged 2 commits intoMay 11, 2026
Merged
Conversation
Collaborator
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
lucasmz-dev
reviewed
May 10, 2026
david-livefront
added
community-pr
app:authenticator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6897 +/- ##
==========================================
- Coverage 86.14% 85.84% -0.30%
==========================================
Files 894 985 +91
Lines 62486 63383 +897
Branches 8937 8964 +27
==========================================
+ Hits 53830 54413 +583
- Misses 5589 5886 +297
- Partials 3067 3084 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
david-livefront
approved these changes
May 11, 2026
Collaborator
|
Thanks @gabrbrand Great catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📔 Objective
Currently a hard coded string is used for the primary button label on tutorial screens in the authenticator app, which makes it impossible to translate. A string resource in now used.