Skip to content

🍒 PM-36475: Update when search icon is shown#6907

Merged
david-livefront merged 1 commit into
release/hotfix-v2026.4.1-bwpmfrom
PM-36475-autofill-search-hotfix
May 11, 2026
Merged

🍒 PM-36475: Update when search icon is shown#6907
david-livefront merged 1 commit into
release/hotfix-v2026.4.1-bwpmfrom
PM-36475-autofill-search-hotfix

Conversation

@david-livefront
Copy link
Copy Markdown
Collaborator

🍒 Cherry-pick from this original PR.

🎟️ Tracking

PM-36475

📔 Objective

This PR updates when the search icon is displayed on the Vault Item Listing Screen. We were hiding the icon when not in the content state but we need to display it when in various Autofill states as ell to allow users to search for pre-existing unmatched items.

@david-livefront david-livefront requested a review from a team as a code owner May 11, 2026 15:08
@github-actions github-actions Bot added the app:password-manager Bitwarden Password Manager app context label May 11, 2026
@david-livefront david-livefront added the t:bug Change Type - Bug label May 11, 2026
@david-livefront david-livefront changed the title PM-36475: Update when search icon is shown 🍒 PM-36475: Update when search icon is shown May 11, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.50%. Comparing base (eace312) to head (c10ef5b).

Files with missing lines Patch % Lines
...t/feature/itemlisting/VaultItemListingViewModel.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           release/hotfix-v2026.4.1-bwpm    #6907      +/-   ##
=================================================================
+ Coverage                          85.47%   85.50%   +0.03%     
=================================================================
  Files                                958      962       +4     
  Lines                              60965    60990      +25     
  Branches                            8646     8653       +7     
=================================================================
+ Hits                               52107    52152      +45     
+ Misses                              5857     5829      -28     
- Partials                            3001     3009       +8     
Flag Coverage Δ
app-data 17.73% <0.00%> (+0.10%) ⬆️
app-ui-auth-tools 20.71% <0.00%> (-0.01%) ⬇️
app-ui-platform 15.92% <0.00%> (-0.01%) ⬇️
app-ui-vault 26.62% <75.00%> (+<0.01%) ⬆️
authenticator 6.56% <0.00%> (+0.02%) ⬆️
lib-core-network-bridge 4.28% <0.00%> (+<0.01%) ⬆️
lib-data-ui 1.03% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront
Copy link
Copy Markdown
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront merged commit 12d24ad into release/hotfix-v2026.4.1-bwpm May 11, 2026
25 of 26 checks passed
@david-livefront david-livefront deleted the PM-36475-autofill-search-hotfix branch May 11, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants