Accessibility overlay support for username field and scroll tracking#700
Merged
Accessibility overlay support for username field and scroll tracking#700
Conversation
kspearrin
requested changes
Jan 13, 2020
| return; | ||
| } | ||
|
|
||
| var isUsernameEditText = AccessibilityHelpers.IsUsernameEditText(root, e); |
Member
There was a problem hiding this comment.
I am afraid this is going to cause perf issues. Can we limit this to my specific cases instead of on every event?
|
|
||
| public static bool IsSameNode(AccessibilityNodeInfo info1, AccessibilityNodeInfo info2) | ||
| { | ||
| if(info1 != null && info2 != null) { |
| { | ||
| Point point = null; | ||
| var allEditTexts = GetWindowNodes(root, e, n => EditText(n), false); | ||
| foreach(AccessibilityNodeInfo node in allEditTexts) |
| } | ||
|
|
||
| var isUsernameEditText = AccessibilityHelpers.IsUsernameEditText(root, e); | ||
| var isPasswordEditText = e.Source != null && e.Source.Password; |
Member
There was a problem hiding this comment.
You can leave this as is since it is probably more readable, but just wanted to show you some c# shorthand: var isPasswordEditText = e.Source?.Password ?? false
| break; | ||
| } | ||
| if(e.PackageName == BitwardenPackage) | ||
| if (e.EventType == EventTypes.ViewScrolled) |
|
|
||
| System.Diagnostics.Debug.WriteLine(">>> Accessibility Overlay View {0} X:{1} Y:{2}", | ||
| updateView ? "Updated to" : "Added at", layoutParams.X, layoutParams.Y); | ||
| Point anchorPosition = AccessibilityHelpers.GetOverlayAnchorPosition(_anchorViewHash, root, e); |
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.