Make callbacks from UI thread.#739
Merged
kspearrin merged 1 commit intobitwarden:masterfrom Feb 24, 2020
oldium:fix-callback-thread
Merged
Make callbacks from UI thread.#739kspearrin merged 1 commit intobitwarden:masterfrom oldium:fix-callback-thread
kspearrin merged 1 commit intobitwarden:masterfrom
oldium:fix-callback-thread
Conversation
Merged
Author
|
Please review the threading also in iOS, I have not checked that (no iOS device). |
kspearrin
requested changes
Feb 24, 2020
The code expects to be called form UI thread, but it loks like JavaScript callbacks are not. Switch to UI thread when invoking a callback. Signed-off-by: Oldřich Jedlička <oldium.pro@gmail.com>
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code expects to be called form UI thread, but it looks like JavaScript
callbacks are not. Switch to UI thread when invoking a callback.
This is a better fix than #738, because this fixes the whole callback thread issue.