Skip to content

Wait for app to resume before attempting to set Application.Current.MainPage#757

Merged
mpbw2 merged 1 commit intomasterfrom
bugfix-duo
Mar 5, 2020
Merged

Wait for app to resume before attempting to set Application.Current.MainPage#757
mpbw2 merged 1 commit intomasterfrom
bugfix-duo

Conversation

@mpbw2
Copy link
Contributor

@mpbw2 mpbw2 commented Mar 5, 2020

Workaround for older bug in Xamarin.Forms by waiting for app to resume before attempting to set Application.Current.MainPage. Fixed in latest Xamarin.Forms 4.4.0.x but it's too dangerous to swap that out so close to a release.

This fixes the issue with Duo that only occurs when you leave the Bitwarden app completely to acknowledge the push (in recent versions of Android you can ack the push directly from the Duo notification, never leaving the Bitwarden app)

…e before attempting to set Application.Current.MainPage
@mpbw2 mpbw2 requested a review from kspearrin March 5, 2020 20:30
@mpbw2 mpbw2 linked an issue Mar 5, 2020 that may be closed by this pull request
@mpbw2 mpbw2 merged commit 6ffb313 into master Mar 5, 2020
@mpbw2 mpbw2 deleted the bugfix-duo branch March 5, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android: App crashes when trying to login with Duo on Android Samsung S10.

2 participants