Skip to content

Add support for Vivaldi snapshot browser #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpbw2 merged 2 commits into from
Apr 6, 2020
Merged

Add support for Vivaldi snapshot browser #822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f93ea0c
Add support for Vivaldi snapshot browser
mpbw2 Apr 6, 2020
04536a5
Added to autofill helpers CompatBrowsers set as well
mpbw2 Apr 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Android/Accessibility/AccessibilityHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ public static class AccessibilityHelpers
new Browser("jp.co.fenrir.android.sleipnir_black", "url_text"),
new Browser("jp.co.fenrir.android.sleipnir_test", "url_text"),
new Browser("com.vivaldi.browser", "url_bar"),
new Browser("com.vivaldi.browser.snapshot", "url_bar"),
Copy link
Member

@kspearrin kspearrin Apr 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to add this to Autofill Helpers CompatBrowsers?

Copy link
Contributor Author

@mpbw2 mpbw2 Apr 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't appear to make a difference (neither vivaldi seems to work with autofill, at least for me). I can add it anyway if you'd like.

Copy link
Member

@kspearrin kspearrin Apr 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well add it

new Browser("com.feedback.browser.wjbrowser", "addressbar_url"),
}.ToDictionary(n => n.PackageName);

Expand Down
1 change: 1 addition & 0 deletions src/Android/Autofill/AutofillHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ public static class AutofillHelpers
"org.mozilla.rocket",
"org.torproject.torbrowser",
"com.vivaldi.browser",
"com.vivaldi.browser.snapshot",
};

// The URLs are blacklisted from autofilling
Expand Down