[WIP] Ability to create and display xamarin forms page in an ios extension#891
Closed
alexeystrakh wants to merge 1 commit intobitwarden:masterfrom
Closed
[WIP] Ability to create and display xamarin forms page in an ios extension#891alexeystrakh wants to merge 1 commit intobitwarden:masterfrom
alexeystrakh wants to merge 1 commit intobitwarden:masterfrom
Conversation
|
|
Member
|
Hi @alexeystrakh, thanks for the submission! If you're still interested in progressing this PR, can you please sign the CLA (see instructions above). I'll then schedule it for further review. |
Contributor
|
@eliykat We can actually close this one - Alexey is from the Xamarin team and created this for demonstration purposes. |
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shows how to use Xamarin.Forms pages in an iOS extensions. This will allow to move all the native iOS controllers to the shared XF core and implement them with Xaml, MVVM and hot reload.
The key steps are:
CreateViewControllermethodI've tested on sim and device, in release configuration with enabled linker (SDK Only or All) the extension performs well, no issues found with this approach.