Fix for deadlock in iOS autofill & share extensions#960
Merged
Conversation
This was
linked to
issues
Jun 7, 2020
kspearrin
approved these changes
Jun 7, 2020
Contributor
Author
|
@kspearrin is the iOS ci still in development or is that failure legit? |
Member
|
Ignore the GitHub ci for now. |
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced use of
GetAwaiter().GetResult()within autofill and sharing extension view controllers, fixes frozen and/or partially drawn autofill windows when setting up and using autofill.Before:
After:
Also fixed the dark-text-on-dark-background issue for the autofill setup completion header (now matches "success" color used in share extension)
Autofill:
Share: