Resolve passwords being hidden in upgrade path#977
Merged
cscharf merged 1 commit intobitwarden:masterfrom Jun 12, 2020
Merged
Conversation
kspearrin
approved these changes
Jun 12, 2020
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #973.
When a vault is synced, the content is stored using the
Datamodels, since the fallback path relied onCipherResponsedefaulting the value, this did not happen for content already synced. By adding a default value toViewPasswordinCipherDatade-serialized objects will now default withViewPasswordenabled.We need to keep the other fallback as well, since otherwise the
CipherDatawill copy theViewPassword=FalsefromCipherResponse.