This repository was archived by the owner on Mar 6, 2025. It is now read-only.
Merged
Conversation
This reverts commit 0dad6f2.
This reverts commit 49a2eab.
…roject"" This reverts commit 9bf6635.
Rename workflows by appending `_authenticator` to their names.
Renamed the following lanes in the Fastfile to be more specific to the Authenticator module: - `check` to `checkAuthenticator` - `setBuildVersionInfo` to `setAuthenticatorBuildVersionInfo` - `buildDebug` to `buildAuthenticatorDebug` - `buildRelease` to `buildAuthenticatorRelease` - `bundleRelease` to `bundleAuthenticatorRelease` - `distributeReleaseBundleToFirebase` to `distributeAuthenticatorReleaseBundleToFirebase` - `publishReleaseToGooglePlayStore` to `publishAuthenticatorReleaseToGooglePlayStore` Updated the GitHub workflows to use the new lane names. Removed unused `json_key_file` and `package_name` from Appfile. Added `json_key` parameter to `validate_play_store_json_key` lane in `build_authenticator.yml` workflow. Added `package_name` parameter to `publishAuthenticatorReleaseToGooglePlayStore` lane in `build_authenticator.yml` workflow.
Rename the output filenames of the Authenticator bundle and APK to `com.bitwarden.authenticator.aab` and `com.bitwarden.authenticator.apk` respectively. This improves the consistency of filenames across different build variants. Additionally, update `build.gradle.kts` to rename bundle and APK files to include the application ID in the file name, ensuring a unique file name for each build. This ensures consistent filenames regardless of build type or target.
SaintPatrck
requested review from
a team,
brian-livefront,
david-livefront and
phil-livefront
as code owners
Contributor
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
==========================================
- Coverage 44.69% 44.67% -0.02%
==========================================
Files 119 119
Lines 5717 5717
Branches 684 684
==========================================
- Hits 2555 2554 -1
Misses 2981 2981
- Partials 181 182 +1 ☔ View full report in Codecov by Sentry. |
…ename-workflow-files
…on/update-fastfile # Conflicts: # .github/workflows/test_authenticator.yml # fastlane/Fastfile
…sistent-output-filenames
|
|
||
| buildTypes { | ||
| debug { | ||
| applicationIdSuffix = ".dev" |
Collaborator
There was a problem hiding this comment.
With this package name change, do we know if the sync feature will still function properly with the dev builds.
I am unsure if they look for specific package names or not.
Contributor
Author
There was a problem hiding this comment.
I don't see anything in Bitwarden that's looking for Authenticator's appId. Authenticator is what needs knowledge of the correct Bitwarden appId to query for.
…pdate-fastfile # Conflicts: # .github/workflows/build.yml # fastlane/Fastfile
…sistent-output-filenames
vvolkgang
previously approved these changes
Feb 12, 2025
…sistent-output-filenames
# Conflicts: # .github/workflows/build.yml # fastlane/Fastfile
vvolkgang
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
--
📔 Objective
Rename the output filenames of the Authenticator bundle and APK to
com.bitwarden.authenticator.aabandcom.bitwarden.authenticator.apkrespectively. This improves the consistency of filenames across different build variants.Additionally, update
build.gradle.ktsto rename bundle and APK files to include the application ID in the file name, ensuring a unique file name for each build. This ensures consistent filenames regardless of build type or target.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes