Skip to content
This repository was archived by the owner on Mar 6, 2025. It is now read-only.

Conversation

@vvolkgang
Copy link
Member

🎟️ Tracking

PM-17412

📔 Objective

Retrieve firebase files from remote container

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

SaintPatrck
SaintPatrck previously approved these changes Feb 25, 2025
@SaintPatrck SaintPatrck self-requested a review February 25, 2025 15:32
@SaintPatrck SaintPatrck dismissed their stale review February 25, 2025 15:32

test failed

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

Logo
Checkmarx One – Scan Summary & Details35044706-6543-4464-81c2-041030b3218f

Great job, no security vulnerabilities found in this Pull Request

@vvolkgang vvolkgang force-pushed the repo-migration/firebase-files branch from a799778 to f2e3d97 Compare February 25, 2025 21:34
@vvolkgang vvolkgang changed the title [PM-17412] Retrieve firebase files from container [PM-17412] Retrieve firebase files from container and remove ui-test version ref Feb 25, 2025
@vvolkgang vvolkgang force-pushed the repo-migration/firebase-files branch from f9a9fea to d8d0b8b Compare February 25, 2025 21:42
@vvolkgang vvolkgang disabled auto-merge February 25, 2025 22:27
@vvolkgang vvolkgang enabled auto-merge (squash) February 25, 2025 22:29
@codecov
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.56%. Comparing base (6b63218) to head (872e660).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
+ Coverage   44.55%   44.56%   +0.01%     
==========================================
  Files         119      119              
  Lines        5717     5717              
  Branches      684      684              
==========================================
+ Hits         2547     2548       +1     
  Misses       2988     2988              
+ Partials      182      181       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vvolkgang vvolkgang merged commit fb792a6 into main Feb 26, 2025
9 checks passed
@vvolkgang vvolkgang deleted the repo-migration/firebase-files branch February 26, 2025 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants