Skip to content

[CL-1137] Remove unecessary toggle-width componet#19782

Merged
willmartian merged 1 commit intomainfrom
uif/remove-side-nav
Mar 26, 2026
Merged

[CL-1137] Remove unecessary toggle-width componet#19782
willmartian merged 1 commit intomainfrom
uif/remove-side-nav

Conversation

@Hinton
Copy link
Copy Markdown
Member

@Hinton Hinton commented Mar 26, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/CL-1137

📔 Objective

The webvault is now responsive, and there is no purpose for the old toggle-width component. This also migrates the web-side-nav to signals and OnPush change detection.

📸 Screenshots

image

@Hinton Hinton requested a review from a team as a code owner March 26, 2026 16:21
@Hinton Hinton requested a review from BryanCunningham March 26, 2026 16:21
@Hinton Hinton changed the title Remove unecessary toggle-width componet [CL-1137] Remove unecessary toggle-width componet Mar 26, 2026
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.49%. Comparing base (473929f) to head (42b4114).
⚠️ Report is 209 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/web/src/app/layouts/web-side-nav.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19782      +/-   ##
==========================================
- Coverage   46.51%   46.49%   -0.03%     
==========================================
  Files        3842     3850       +8     
  Lines      114480   114912     +432     
  Branches    17479    17508      +29     
==========================================
+ Hits        53246    53423     +177     
- Misses      58800    59056     +256     
+ Partials     2434     2433       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Detailsa5550c1f-56e1-4c7e-b956-d64b7fda8afc

Great job! No new security vulnerabilities introduced in this pull request

@willmartian willmartian merged commit e6e8213 into main Mar 26, 2026
71 checks passed
@willmartian willmartian deleted the uif/remove-side-nav branch March 26, 2026 22:15
@djsmith85 djsmith85 added the web label Apr 2, 2026
@djsmith85 djsmith85 added the t:tech-debt Change Type - Tech debt label Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:tech-debt Change Type - Tech debt web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants