Skip to content

[PM-19168] Remove Archive Feature Flag#19829

Merged
nick-livefront merged 2 commits intomainfrom
vault/pm-19168/remove-archive-ff
Mar 30, 2026
Merged

[PM-19168] Remove Archive Feature Flag#19829
nick-livefront merged 2 commits intomainfrom
vault/pm-19168/remove-archive-ff

Conversation

@nick-livefront
Copy link
Copy Markdown
Collaborator

@nick-livefront nick-livefront commented Mar 27, 2026 •
edited by atlassian bot
Loading

🎟️ Tracking

PM-19168

📔 Objective

Removes the Archive feature flag and refactor all implementation points to use the "true" path

📸 Screenshots

N/A

@nick-livefront nick-livefront requested a review from a team as a code owner March 27, 2026 20:40
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 27, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
12.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

Logo
Checkmarx One – Scan Summary & Details – e6c36333-24e0-467b-a046-5812b7e5ac9b

Great job! No new security vulnerabilities introduced in this pull request

jengstrom-bw
jengstrom-bw reviewed Mar 27, 2026
View reviewed changes
Comment thread apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.spec.ts
Copy link
Copy Markdown
Contributor

@jengstrom-bw jengstrom-bw Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Are the additions of the premium components and services part of this feature flag removal?

Copy link
Copy Markdown
Collaborator Author

@nick-livefront nick-livefront Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, I should have called this out. I removed archiveEnabled which was default to false in the test. With the removal it was now treated as true which had downstream impacts of the app-premium-badge now being present in the test runs.

These imports were needed for that to render correctly

jengstrom-bw
jengstrom-bw approved these changes Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jengstrom-bw jengstrom-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying that question. Looks good!

@nick-livefront nick-livefront merged commit 30ab005 into main Mar 30, 2026
280 checks passed
@nick-livefront nick-livefront deleted the vault/pm-19168/remove-archive-ff branch March 30, 2026 15:23
@djsmith85 djsmith85 added desktop Desktop Application cli CLI Application web browser Browser Extension feature-flag labels Apr 2, 2026
@djsmith85 djsmith85 added the t:feature Change Type - Feature Development label Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jengstrom-bw jengstrom-bw jengstrom-bw approved these changes

Assignees

No one assigned

Labels

browser Browser Extension cli CLI Application desktop Desktop Application feature-flag t:feature Change Type - Feature Development web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nick-livefront @jengstrom-bw @djsmith85