[CL-1130] Fix storybook a11y and console errors for dirt files#19919
Open
[CL-1130] Fix storybook a11y and console errors for dirt files#19919
Conversation
Contributor
|
New Issues (1)Checkmarx found the following issues in this Pull Request
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19919 +/- ##
=======================================
Coverage 47.05% 47.05%
=======================================
Files 3894 3894
Lines 117403 117403
Branches 17975 17975
=======================================
Hits 55245 55245
Misses 59671 59671
Partials 2487 2487 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Banrion
approved these changes
Apr 16, 2026
| "message": "Your bank account needs to be verified before it can be used for this upgrade. Please verify your bank account or choose a different payment method." | ||
| }, | ||
| "export": { | ||
| "message": "Export" |
Contributor
There was a problem hiding this comment.
❓ Do we still need to add the message if the export text was removed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
CL-1130
📔 Objective
We are working through Storybook errors related to accessibility and general console errors (usually story setup issues). This PR fixes current errors in dirt-owned code. Specifically the fixes in this PR are:
messages.json. Please note that this will affect prod code, not just story code.I think it might be good for the team's designer to take a look at the UI Review prior to approving this PR.