Skip to content

[PM-31270] New default argon2id in change kdf component#20058

Merged
mzieniukbw merged 5 commits intomainfrom
km/pm-31270-new-default-argon2-in-change-kdf-component
Apr 15, 2026
Merged

[PM-31270] New default argon2id in change kdf component#20058
mzieniukbw merged 5 commits intomainfrom
km/pm-31270-new-default-argon2-in-change-kdf-component

Conversation

@mzieniukbw
Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-31270

📔 Objective

Adjusted default Argon2 configuration when user manually selects Argon2Id in change kdf component to:
Iterations: 6
Memory: 32MB
Parallelism: 4

Also refactored PBKDF2KdfConfig and Argon2KdfConfig:

  • explicit defaults with createDefault function, instead of relying on the constructor with all optional arguments.
  • kdf fields are readonly, immutable - prevents change-kdf.component.ts from modifying the global const, like it was before.

📸 Screenshots

New Argon2Id defaults when changing KDF

Screen.Recording.2026-04-08.at.17.04.20.mov

@mzieniukbw mzieniukbw requested review from a team as code owners April 8, 2026 16:05
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.76%. Comparing base (f3aff99) to head (08ddcd6).
⚠️ Report is 94 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20058      +/-   ##
==========================================
+ Coverage   46.57%   46.76%   +0.19%     
==========================================
  Files        3879     3879              
  Lines      116030   116210     +180     
  Branches    17646    17699      +53     
==========================================
+ Hits        54042    54351     +309     
+ Misses      59532    59390     -142     
- Partials     2456     2469      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Logo
Checkmarx One – Scan Summary & Detailsd019eebd-7a30-479c-b6a2-800a9b2eff7e


New Issues (9) Checkmarx found the following issues in this Pull Request
# Severity Issue Source File / Package Checkmarx Insight
1 HIGH CVE-2026-34770 Npm-electron-39.2.6
detailsDescription: Electron is a framework for writing cross-platform desktop applications using JavaScript, HTML and CSS. Prior to versions 38.8.6, 39.x prior to 39....
Attack Vector: LOCAL
Attack Complexity: HIGH
Vulnerable Package
2 HIGH CVE-2026-34771 Npm-electron-39.2.6
detailsDescription: Electron is a framework for writing cross-platform desktop applications using JavaScript, HTML and CSS. Prior to versions 38.8.6, 39.x prior to 39....
Attack Vector: NETWORK
Attack Complexity: HIGH
Vulnerable Package
3 HIGH CVE-2026-34774 Npm-electron-39.2.6
detailsDescription: Electron is a framework for writing cross-platform desktop applications using JavaScript, HTML and CSS. Prior to versions 39.8.1, 40.x prior to 40....
Attack Vector: NETWORK
Attack Complexity: HIGH
Vulnerable Package
4 HIGH SSRF /libs/common/src/services/api.service.ts: 1327
detailsThe application sends a request to a remote server, for some resource, using createRequest in /libs/common/src/services/api.service.ts:1270. How...
Attack Vector
5 HIGH SSRF /libs/common/src/services/api.service.ts: 1335
detailsThe application sends a request to a remote server, for some resource, using createRequest in /libs/common/src/services/api.service.ts:1270. How...
Attack Vector
6 HIGH SSRF /libs/common/src/services/api.service.ts: 1328
detailsThe application sends a request to a remote server, for some resource, using createRequest in /libs/common/src/services/api.service.ts:1270. How...
Attack Vector
7 HIGH SSRF /libs/common/src/services/api.service.ts: 1327
detailsThe application sends a request to a remote server, for some resource, using createRequest in /libs/common/src/services/api.service.ts:1241. How...
Attack Vector
8 HIGH SSRF /libs/common/src/services/api.service.ts: 1335
detailsThe application sends a request to a remote server, for some resource, using createRequest in /libs/common/src/services/api.service.ts:1241. How...
Attack Vector
9 HIGH SSRF /libs/common/src/services/api.service.ts: 1328
detailsThe application sends a request to a remote server, for some resource, using createRequest in /libs/common/src/services/api.service.ts:1241. How...
Attack Vector

Fixed Issues (1) Great job! The following issues were fixed in this Pull Request
Severity Issue Source File / Package
HIGH SSRF /libs/common/src/services/api.service.ts: 1343

quexten
quexten previously approved these changes Apr 9, 2026
addisonbeck
addisonbeck previously approved these changes Apr 9, 2026
Thomas-Avery
Thomas-Avery previously approved these changes Apr 9, 2026
Copy link
Copy Markdown
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread libs/common/src/auth/password-prelogin/password-prelogin.model.ts
@sonarqubecloud
Copy link
Copy Markdown

@mzieniukbw mzieniukbw enabled auto-merge (squash) April 14, 2026 22:46
@mzieniukbw mzieniukbw merged commit d40bbcf into main Apr 15, 2026
144 of 146 checks passed
@mzieniukbw mzieniukbw deleted the km/pm-31270-new-default-argon2-in-change-kdf-component branch April 15, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants