Skip to content

[PM-34887] - Improve responsiveness of AC collection table#20104

Open
jaasen-livefront wants to merge 14 commits intomainfrom
PM-34887
Open

[PM-34887] - Improve responsiveness of AC collection table#20104
jaasen-livefront wants to merge 14 commits intomainfrom
PM-34887

Conversation

@jaasen-livefront
Copy link
Copy Markdown
Collaborator

@jaasen-livefront jaasen-livefront commented Apr 10, 2026

🎟️ Tracking

PM-34887

📔 Objective

Improves the vault items table layout with responsive column visibility and several related polish fixes.

Responsive columns (org vault table):

  • LG (1024px): Groups column visually hidden via tw-hidden lg:tw-table-cell
  • SM (640px): Permission column visually hidden via tw-hidden sm:tw-table-cell

Columns are hidden with CSS rather than removed from the DOM, consistent with the existing Owner column pattern, preserving accessibility and screen reader support.

Permission column:

  • Text always truncates (tw-truncate) with a native [title] tooltip revealing the full value on hover

Last column width (flag-gated):

  • When PM28091_AddCopyAndQuickLaunchActions is enabled, the actions column header widens from tw-w-12tw-w-28 to accommodate up to 3 icon buttons; uses the existing showCopyAndLaunchActions$ observable added to VaultItemsComponent

AC vault filter sidebar:

  • Updated to match the individual vault's gutter pattern (-tw-mx-2.5 / tw-px-2.5) so the filter sidebar renders at the same visual width in both the org and individual vault views

📸 Screenshots

Screenshot 2026-04-10 at 3 14 10 PM
Screen.Recording.2026-04-14.at.10.14.08.AM.mov

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

Logo
Checkmarx One – Scan Summary & Details6ebcf713-dccf-4ac9-adc4-d3953ce242da

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.07%. Comparing base (29f4f6d) to head (fb50610).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20104   +/-   ##
=======================================
  Coverage   47.07%   47.07%           
=======================================
  Files        3895     3895           
  Lines      117425   117429    +4     
  Branches    17979    17979           
=======================================
+ Hits        55273    55277    +4     
  Misses      59666    59666           
  Partials     2486     2486           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaasen-livefront jaasen-livefront marked this pull request as ready for review April 14, 2026 17:59
@jaasen-livefront jaasen-livefront requested review from a team as code owners April 14, 2026 17:59
nikwithak
nikwithak previously approved these changes Apr 15, 2026
Copy link
Copy Markdown
Contributor

@nikwithak nikwithak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

r-tome
r-tome previously approved these changes Apr 15, 2026
@jaasen-livefront jaasen-livefront dismissed stale reviews from r-tome and nikwithak via ceb93d7 April 16, 2026 23:27
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants