[PM-33933] Update autofill dialog for 'never' match setting#20189
Draft
nikwithak wants to merge 3 commits intovault/pm-32375from
Draft
[PM-33933] Update autofill dialog for 'never' match setting#20189nikwithak wants to merge 3 commits intovault/pm-32375from
nikwithak wants to merge 3 commits intovault/pm-32375from
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## vault/pm-32375 #20189 +/- ##
==================================================
+ Coverage 46.82% 46.99% +0.16%
==================================================
Files 3883 3891 +8
Lines 116517 117323 +806
Branches 17751 17941 +190
==================================================
+ Hits 54561 55133 +572
- Misses 59476 59709 +233
- Partials 2480 2481 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
New Issues (5)Checkmarx found the following issues in this Pull Request
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-33933
📔 Objective
Updates the Autofill modal to give special messaging when the Autofill criteria is set to "Never". Note: This is rebased onto #20071 , and consumes several style changes included in that PR, so that PR will have to go before this one can merge in.
📸 Screenshots
No URI match (copy changed slightly to add "or match criteria"):


URI matches, set to never:

No site saved (unchanged from previous behavior):
