Skip to content

[PM-33933] Update autofill dialog for 'never' match setting#20189

Draft
nikwithak wants to merge 3 commits intovault/pm-32375from
vault/pm-33933
Draft

[PM-33933] Update autofill dialog for 'never' match setting#20189
nikwithak wants to merge 3 commits intovault/pm-32375from
vault/pm-33933

Conversation

@nikwithak
Copy link
Copy Markdown
Contributor

@nikwithak nikwithak commented Apr 15, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-33933

📔 Objective

Updates the Autofill modal to give special messaging when the Autofill criteria is set to "Never". Note: This is rebased onto #20071 , and consumes several style changes included in that PR, so that PR will have to go before this one can merge in.

📸 Screenshots

No URI match (copy changed slightly to add "or match criteria"):
Screenshot 2026-04-15 at 3 04 54 PM
Screenshot 2026-04-15 at 3 05 21 PM

URI matches, set to never:
Screenshot 2026-04-15 at 3 06 15 PM

No site saved (unchanged from previous behavior):
Screenshot 2026-04-15 at 3 29 12 PM

@nikwithak nikwithak changed the title Vault/pm 33933 [PM-33933] Update autofill dialog for 'never' match setting Apr 15, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.99%. Comparing base (68b835b) to head (fdbc074).
⚠️ Report is 48 commits behind head on vault/pm-32375.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...n-dialog/autofill-confirmation-dialog.component.ts 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           vault/pm-32375   #20189      +/-   ##
==================================================
+ Coverage           46.82%   46.99%   +0.16%     
==================================================
  Files                3883     3891       +8     
  Lines              116517   117323     +806     
  Branches            17751    17941     +190     
==================================================
+ Hits                54561    55133     +572     
- Misses              59476    59709     +233     
- Partials             2480     2481       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

Logo
Checkmarx One – Scan Summary & Details1e586c50-1fef-487a-9ba2-a836679df480


New Issues (5) Checkmarx found the following issues in this Pull Request
# Severity Issue Source File / Package Checkmarx Insight
1 HIGH CVE-2026-2359 Npm-multer-2.0.2
detailsRecommended version: 2.1.1
Description: Multer is a node.js middleware for handling `multipart/form-data`. A vulnerability in Multer prior to version 2.1.0 allows an attacker to trigger a...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
2 HIGH CVE-2026-27959 Npm-koa-3.1.1
detailsRecommended version: 3.1.2
Description: Koa is middleware for Node.js using ES2017 async functions. Prior to versions 2.16.4 and 3.x prior to 3.1.2, Koa's `ctx.hostname` API performs naiv...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
3 HIGH CVE-2026-3304 Npm-multer-2.0.2
detailsRecommended version: 2.1.1
Description: Multer is a node.js middleware for handling `multipart/form-data`. A vulnerability in Multer prior to version 2.1.0 and 3.0.0-alpha1 allows an att...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
4 HIGH CVE-2026-3520 Npm-multer-2.0.2
detailsRecommended version: 2.1.1
Description: Multer is a node.js middleware for handling `multipart/form-data`. A vulnerability in Multer prior to version 2.1.1 allows an attacker to trigger a...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
5 MEDIUM Missing_HSTS_Header /apps/cli/src/auth/commands/login.command.ts: 571
detailsThe web-application does not define an HSTS header, leaving it vulnerable to attack.
Attack Vector

Fixed Issues (1) Great job! The following issues were fixed in this Pull Request
Severity Issue Source File / Package
MEDIUM Missing_HSTS_Header /apps/browser/src/autofill/services/targeting-rules-data.service.ts: 199

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant