[PM-35240] Add sync before forced kdf migration#20193
Open
Conversation
Contributor
|
New Issues (4)Checkmarx found the following issues in this Pull Request
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20193 +/- ##
==========================================
+ Coverage 46.80% 46.98% +0.17%
==========================================
Files 3885 3891 +6
Lines 116980 117332 +352
Branches 17890 17943 +53
==========================================
+ Hits 54754 55124 +370
+ Misses 59744 59726 -18
Partials 2482 2482 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-35240
📔 Objective
In some conditions, it is possible for the server KDF to change, without the client stored KDF changing. One of these cases is as follows:
in this case, we would get a second KDF migration, or even second KDF migration prompt in case the unlock method was not master-password.
This PR confirms that a "needs migration" actually needs a migration by doing another sync. Note, that the sync is not ideal here but accepted as a temporary measure. It should be replaced with a custom endpoint for updating decryption options in the future, and bound to the correct user id.
📸 Screenshots