Skip to content

[PM-35243] Update cancel survey options for Teams and Enterprise#20199

Open
amorask-bitwarden wants to merge 6 commits intomainfrom
billing/PM-35243/update-cancel-survey-options
Open

[PM-35243] Update cancel survey options for Teams and Enterprise#20199
amorask-bitwarden wants to merge 6 commits intomainfrom
billing/PM-35243/update-cancel-survey-options

Conversation

@amorask-bitwarden
Copy link
Copy Markdown
Contributor

@amorask-bitwarden amorask-bitwarden commented Apr 16, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-35243

📔 Objective

Updates the offboarding survey component to show Teams/Enterprise-specific display text for cancellation reasons and removes the "other" option for business-tier plans (Teams, Enterprise, Teams Starter). Adds productTier to the dialog params for clean plan detection via ProductTierType instead of enumerating 18+ PlanType variants. No changes for Premium or Families subscriptions — their survey options remain unchanged.

📸 Screenshots

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2026

Logo
Checkmarx One – Scan Summary & Details65e44686-374a-4f12-af49-2b2e6f99795b


New Issues (1) Checkmarx found the following issues in this Pull Request
# Severity Issue Source File / Package Checkmarx Insight
1 MEDIUM Missing_HSTS_Header apps/web/src/app/dirt/reports/pages/inactive-two-factor-report.component.ts: 148
detailsThe web-application does not define an HSTS header, leaving it vulnerable to attack.
Attack Vector

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.05%. Comparing base (696ce48) to head (e3a3983).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...app/billing/shared/offboarding-survey.component.ts 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20199      +/-   ##
==========================================
- Coverage   47.05%   47.05%   -0.01%     
==========================================
  Files        3894     3894              
  Lines      117403   117412       +9     
  Branches    17975    17981       +6     
==========================================
+ Hits        55245    55246       +1     
- Misses      59671    59679       +8     
  Partials     2487     2487              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amorask-bitwarden amorask-bitwarden marked this pull request as ready for review April 16, 2026 18:32
@amorask-bitwarden amorask-bitwarden requested a review from a team as a code owner April 16, 2026 18:32
@sonarqubecloud
Copy link
Copy Markdown

@amorask-bitwarden amorask-bitwarden added the hold Hold this PR or item until later; DO NOT MERGE label Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold Hold this PR or item until later; DO NOT MERGE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants