Conversation
…-secrets-manager-for-msp-managed-organizations
|
New Issues
|
…-secrets-manager-for-msp-managed-organizations
…p-managed-organizations
Member
Author
|
Fixed some logic - no need to check the providerType, only whether the org has a provider at all. |
BlackDex
pushed a commit
to BlackDex/bitwarden-clients
that referenced
this pull request
Nov 21, 2023
…warden#6392) * Hide Add SM component on sub page for MSPs * Hide Add SM component on create org page for MSPs * Use hasProvider instead of providerType
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Type of change
Objective
We do not support MSP access to Secrets Manager, so we need to prevent:
The internal Bitwarden Portal will not have this restriction, so that Customer Success can make case-by-case exceptions if required.
Server changes: bitwarden/server#3297
Code changes
OrganizationPlansComponent- hide sm-subscribe component if accessed via the provider portalOrganizationSubscriptionCloudComponent- hide sm-subscribe component if the org has a providerNote that there is no client-side block on adding an existing org with SM to a provider. We just rely on the server-side error message via toast.
Screenshots
Before you submit