[SG-796] Mobile getting started updates #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
874bc73
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ae0374f7.contributing-docs.pages.dev |
| Branch Preview URL: | https://mobile-getting-started-updat.contributing-docs.pages.dev |
Member
|
Seems I forgot to migrate the previous documentation about CF tunnels, https://github.com/bitwarden/contributing-docs-archive/blob/production/internal/docs/server/cf-tunnel.md. I think we should look into combining the ngrok portions with our old CF doc, and move this into a common place since there are non mobile reasons to want to tunnel things. And we avoid duplicating the same text twice. |
Member
|
We now have a proper section on tunnels in https://contributing.bitwarden.com/getting-started/server/tunnel. Should we look into lifting it out into Tools so we can reference it from server, clients and mobile? |
Contributor
Author
I believe it is the best course of action. |
Hinton
reviewed
Dec 20, 2022
Hinton
reviewed
Dec 20, 2022
trmartin4
reviewed
Dec 29, 2022
Member
trmartin4
left a comment
trmartin4
left a comment
There was a problem hiding this comment.
Thank you for adding this documentation! I made a few superficial suggestions.
trmartin4
requested changes
Jan 4, 2023
Member
trmartin4
left a comment
trmartin4
left a comment
There was a problem hiding this comment.
Looks great! Just a few more suggestions.
trmartin4
previously approved these changes
Jan 6, 2023
Member
trmartin4
left a comment
trmartin4
left a comment
There was a problem hiding this comment.
Looks good! Thank you for making these updates.
trmartin4
previously approved these changes
Jan 9, 2023
…on regarding testing mobile notifications.
* Bold selected navbar items for accessibility * Include dark mode icon
* Added push notification documentation. * Changes from Oscar's review. * Restructured client and server sections. * Changed FCM link * Fixed notes. * More notes fixes. * More spacing changes. * Removed header. * More fixes. * Re-ordered sections to match between mobile and other clients. * Additional changes from Oscar's suggestions. * Update docs/architecture/push-notifications/non-mobile.md Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com> * Missing "the" * Updates to add links to classes. * Added classes to non-mobile. Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
* Add advanced setup which was missing * Add tunnel * Add scim * Move all tunnel instructions to tunnel * Mark as bitwarden * Fix title capitalization * More title fixes
* Extended title for ADR 0013 * Updated title at Oscar's suggestion. * Renamed ADR 0013 * Removed title as it is duplicated elsewhere. Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com> Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
Co-authored-by: Todd Martin <106564991+trmartin4@users.noreply.github.com>
Co-authored-by: Todd Martin <106564991+trmartin4@users.noreply.github.com>
* Add code review guidelines
* Improve safari development documentation
* License docs as CC by-nc-nd * Mimic license files of server repository * Specify license * Fix CC license links * Add license file extensions
* Moved browser environment clarification from archived repo. * Addressed PR recommendations.
andrebispo5
force-pushed
the
mobile-getting-started-update
branch
from
6ce1c92 to
73e56cd
Compare
# Conflicts: # docs/getting-started/server/tunnel.md
trmartin4
approved these changes
Jan 10, 2023
fedemkr
pushed a commit
that referenced
this pull request
Jan 10, 2023
* [SG-796] Add another way to connect mobile to local server. Information regarding testing mobile notifications. * [SG-796] Add section Testing Passwordless Locally * [SG-796] code format * Add lunr search (#21) https://github.com/praveenn77/docusaurus-lunr-search * [SG-796] fix note * Fix typo for Android's adb tool (#27) * Add server pre-commit hook instructions (#26) * Fix logo overlap on small screens (#31) * Theme tweaks (#32) * Bold selected navbar items for accessibility * Include dark mode icon * Added push notification documentation (#13) * Added push notification documentation. * Changes from Oscar's review. * Restructured client and server sections. * Changed FCM link * Fixed notes. * More notes fixes. * More spacing changes. * Removed header. * More fixes. * Re-ordered sections to match between mobile and other clients. * Additional changes from Oscar's suggestions. * Update docs/architecture/push-notifications/non-mobile.md Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com> * Missing "the" * Updates to add links to classes. * Added classes to non-mobile. Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com> * Add missing internal documentation (#33) * Add advanced setup which was missing * Add tunnel * Add scim * Move all tunnel instructions to tunnel * Mark as bitwarden * Fix title capitalization * More title fixes * Extended title for ADR 0013 (#30) * Extended title for ADR 0013 * Updated title at Oscar's suggestion. * Renamed ADR 0013 * Removed title as it is duplicated elsewhere. Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com> Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com> * [SG-796] Update docs with tunneling docs * Add notes to tunneling docs. Fix note on mobile docs. * remove unused images * [SG-796] move note inline Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com> * [SG-796] Change reference to tunnels * Apply suggestions from code review Co-authored-by: Todd Martin <106564991+trmartin4@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Todd Martin <106564991+trmartin4@users.noreply.github.com> * fix list formatting. * test fix: bitwarden tag * Add code review guidelines (#17) * Add code review guidelines * Fix info callout in MAS dev page (#38) * Added Captcha documentation (#40) * Remove optional comments (#36) * Add contributing ... (#34) * Improve safari development documentation (#25) * Improve safari development documentation * License docs as CC by-nc-nd (#39) * License docs as CC by-nc-nd * Mimic license files of server repository * Specify license * Fix CC license links * Add license file extensions * Added browser environment setup (#37) * Moved browser environment clarification from archived repo. * Addressed PR recommendations. * Added clarification on how to name SQL scripts. (#45) * linter run Co-authored-by: Matt Gibson <mgibson@bitwarden.com> Co-authored-by: Matt Bishop <matt@withinfocus.com> Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com> Co-authored-by: Todd Martin <106564991+trmartin4@users.noreply.github.com> Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com> Co-authored-by: Robyn MacCallum <robyntmaccallum@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Updates to mobile getting started section: