Remove Okta docs #718
Remove Okta docs #718
Conversation
Deploying contributing-docs with
|
| Latest commit: |
890a219
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bd5aa3f7.contributing-docs.pages.dev |
| Branch Preview URL: | https://remove-okta-sso-docs.contributing-docs.pages.dev |
|
Great job! No new security vulnerabilities introduced in this pull request |
|
Claude finished @trmartin4's task —— View job Review Complete
SummaryThis PR successfully consolidates SSO documentation into a single page following Okta's removal of their free Developer preview. The documentation is well-structured and clear. FindingsFinding 1: PR description and title are clear and well-written, with appropriate context about why this change was made. Finding 2: The consolidation effectively merges Finding 3: Documentation follows the repository style guide with numbered instructions, code blocks, and proper formatting. Finding 4: Custom word removal ( Finding 5: The "Desktop client" section was properly restructured from a standalone note into a full troubleshooting entry with detailed workaround steps. Additional Notes
Good work on maintaining consistent formatting and comprehensive troubleshooting coverage. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| [http://localhost:8090/simplesaml](http://localhost:8090/simplesaml) and clicking Authentication | ||
| → Test Configured Authentication Sources → `example-userpass`. You should be able to log in with | ||
| the users you’ve configured. | ||
|
|
There was a problem hiding this comment.
The navigation path uses "→" (arrow) here, but step 88 above uses "clicking Authentication → Test Configured..." which is consistent. However, the deleted local.md file used commas in the path: "Authentication → test configured authentication sources → example-userpass" (lowercase "test").
The current version capitalizes "Test" which is more consistent with UI styling, but should we standardize whether we use arrows or commas for multi-level navigation paths?
| - X509 Public Certificate | ||
| - Get this by opening a new tab and navigating to the Entity ID URL above. It will open (or | ||
| download) an XML file. Copy and paste the value _between_ the `<ds:X509Certificate>` tags | ||
| (it should look like a base64-encoded string). |
There was a problem hiding this comment.
🎨 Consider clarifying "between" for better precision
The instruction says to copy the value "between" the tags, which is correct. However, the previous version in local.md used similar wording. For absolute clarity with technical users, consider: "Copy and paste the certificate value contained within the <ds:X509Certificate> tags (not including the opening and closing tags themselves)."
This removes any ambiguity about whether "between" includes the tags or not.
📔 Objective
With the removal of the free Developer preview in Okta, we have moved away from that being an option for local SSO development.
This PR consolidates the SSO docs into a single page since there are no more options other than the local SAML configuration.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes