Skip to content

Conversation

@aj-rosado
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13027

📔 Objective

Setting textSelectionEnabled on BitwardenTextValueField as true in order to allow user to long press copy all textfields

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.14%. Comparing base (b62432c) to head (dac9684).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1036      +/-   ##
==========================================
- Coverage   89.15%   89.14%   -0.01%     
==========================================
  Files         662      662              
  Lines       41596    41596              
==========================================
- Hits        37085    37082       -3     
- Misses       4511     4514       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsd62e8302-9215-4a16-ad4c-2f45be277e2f

No New Or Fixed Issues Found

@aj-rosado aj-rosado marked this pull request as ready for review October 11, 2024 11:31
@aj-rosado aj-rosado merged commit 87640a9 into main Oct 15, 2024
9 checks passed
@aj-rosado aj-rosado deleted the PM-13027/long-press-copy-textfields branch October 15, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to select text in a Secure Notes/Login "Notes" field Unable to select text in a notes field

3 participants