Skip to content

Conversation

@matt-livefront
Copy link
Collaborator

@matt-livefront matt-livefront commented Nov 6, 2025

🎟️ Tracking

PM-26063

📔 Objective

Updates the Authenticator's settings view to match the latest designs, in preparation for adding the Flight Recorder. I also removed SettingsMenuField after migrating the last remaining usages to BitwardenMenuField.

📸 Screenshots

Before After
Screenshot 2025-11-06 at 3 35 43 PM Screenshot 2025-11-06 at 3 35 47 PM Screenshot 2025-11-06 at 3 12 17 PM Screenshot 2025-11-06 at 3 12 20 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@matt-livefront matt-livefront requested a review from a team as a code owner November 6, 2025 22:07
@claude
Copy link

claude bot commented Nov 6, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Logo
Checkmarx One – Scan Summary & Details23a4ef96-9bb5-420a-894b-348f83ac1730

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 92.79279% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.67%. Comparing base (e030fbf) to head (7ae5fc7).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...d/UI/Platform/Settings/Settings/SettingsView.swift 93.33% 6 Missing ⚠️
...latform/Application/Views/BitwardenMenuField.swift 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2113      +/-   ##
==========================================
- Coverage   85.23%   83.67%   -1.56%     
==========================================
  Files        1709     1976     +267     
  Lines      145501   161210   +15709     
==========================================
+ Hits       124019   134897   +10878     
- Misses      21482    26313    +4831     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matt-livefront matt-livefront merged commit 73fc2d8 into main Nov 6, 2025
15 of 16 checks passed
@matt-livefront matt-livefront deleted the matt/PM-26063-authenticator-settings-view branch November 6, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants